-
Notifications
You must be signed in to change notification settings - Fork 56
fix(PM-1175): Applied email not sent #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
339c8ab
debug apply copilot
hentrymartin 9be8c5f
debug apply copilot
hentrymartin d95af0d
fix: use correct field
hentrymartin 126ea0b
fix: use correct field
hentrymartin 3875c3e
fix: lowercase null exception
hentrymartin 92ee79e
removed debug logs
hentrymartin 70e8e40
removed circle ci configs
hentrymartin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -71,17 +71,25 @@ module.exports = [ | |
const pmRole = await util.getRolesByRoleName(USER_ROLE.PROJECT_MANAGER, req.log, req.id); | ||
const { subjects = [] } = await util.getRoleInfo(pmRole[0], req.log, req.id); | ||
|
||
const creator = await util.getMemberDetailsByUserIds([opportunity.userId], req.log, req.id); | ||
req.log.debug(subjects, 'all manager subjects'); | ||
|
||
const creator = await util.getMemberDetailsByUserIds([opportunity.createdBy], req.log, req.id); | ||
|
||
req.log.debug(creator, 'creator'); | ||
|
||
const listOfSubjects = subjects; | ||
if (creator) { | ||
const isCreatorPartofSubjects = subjects.find(item => item.email.toLowerCase() === creator[0].email.toLowerCase()); | ||
req.log.debug(isCreatorPartofSubjects, 'isCreatorPartofSubjects'); | ||
if (!isCreatorPartofSubjects) { | ||
listOfSubjects.push({ | ||
email: creator[0].email, | ||
handle: creator[0].handle, | ||
}); | ||
} | ||
} | ||
|
||
req.log.debug(listOfSubjects, 'final list of subjects'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider removing or adjusting the debug log statement if it is not needed for production. Debug logs can be useful during development but may clutter the log files in a production environment. |
||
|
||
const emailEventType = CONNECT_NOTIFICATION_EVENT.EXTERNAL_ACTION_EMAIL; | ||
const copilotPortalUrl = config.get('copilotPortalUrl'); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.