Skip to content

fix(PM-1175): Applied email not sent #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 16, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ workflows:
context : org-global
filters:
branches:
only: ['develop', 'migration-setup', 'pm-1173_1']
only: ['develop', 'migration-setup', 'pm-1175_2']
- deployProd:
context : org-global
filters:
Expand Down
10 changes: 9 additions & 1 deletion src/routes/copilotOpportunityApply/create.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,17 +71,25 @@ module.exports = [
const pmRole = await util.getRolesByRoleName(USER_ROLE.PROJECT_MANAGER, req.log, req.id);
const { subjects = [] } = await util.getRoleInfo(pmRole[0], req.log, req.id);

const creator = await util.getMemberDetailsByUserIds([opportunity.userId], req.log, req.id);
req.log.debug(subjects, 'all manager subjects');

const creator = await util.getMemberDetailsByUserIds([opportunity.createdBy], req.log, req.id);

req.log.debug(creator, 'creator');

const listOfSubjects = subjects;
if (creator) {
const isCreatorPartofSubjects = subjects.find(item => item.email.toLowerCase() === creator[0].email.toLowerCase());
req.log.debug(isCreatorPartofSubjects, 'isCreatorPartofSubjects');
if (!isCreatorPartofSubjects) {
listOfSubjects.push({
email: creator[0].email,
handle: creator[0].handle,
});
}
}

req.log.debug(listOfSubjects, 'final list of subjects');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing or adjusting the debug log statement if it is not needed for production. Debug logs can be useful during development but may clutter the log files in a production environment.


const emailEventType = CONNECT_NOTIFICATION_EVENT.EXTERNAL_ACTION_EMAIL;
const copilotPortalUrl = config.get('copilotPortalUrl');
Expand Down