fix(PM-1175): Applied email not sent #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if (!isCreatorPartofSubjects) { | ||
| listOfSubjects.push({ | ||
| email: creator[0].email, | ||
| handle: creator[0].handle, | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| req.log.debug(listOfSubjects, 'final list of subjects'); |
There was a problem hiding this comment.
Consider removing or adjusting the debug log statement if it is not needed for production. Debug logs can be useful during development but may clutter the log files in a production environment.
|
|
||
| const creator = await util.getMemberDetailsByUserIds([opportunity.createdBy], req.log, req.id); | ||
|
|
||
| req.log.debug(creator, 'creator', opportunity.createdBy); |
There was a problem hiding this comment.
The addition of opportunity.createdBy to the debug log statement provides more context, which can be useful for debugging purposes. However, ensure that this additional information does not expose sensitive data. If opportunity.createdBy contains sensitive information, consider masking or obfuscating it before logging.
hentrymartin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?