Skip to content

add installer tests #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add installer tests #2045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/installer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Installer Test

on:
push:
Copy link
Collaborator

@alixander alixander Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's still on push rather than as a daily job

Copy link
Contributor Author

@danieleades danieleades Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rationale for not wanting this on push?

Copy link
Collaborator

@alixander alixander Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slows down ci for rare changes. i suppose if you want to add a gate that says only run this if the install script changed, it can be on push, but even then it'd have to be grouped under "ci" workflow to avoid the extra noise

branches: [master]
pull_request:

jobs:
test:
name: installer (${{ matrix.os }})
strategy:
matrix:
os: [ubuntu, windows, macos]
runs-on: ${{ matrix.os }}-latest
steps:
- uses: actions/checkout@v4
- name: Install D2
run: |
cat install.sh | sh -s --
Loading