add installer tests #2045
add installer tests #2045
Conversation
alixander
left a comment
alixander
left a comment
There was a problem hiding this comment.
Sorry about the delay in getting to this. I think it's a good addition. Probably in daily though. If you'd like to make the changes, including signing your commit, please update this PR. Otherwise I can make them in another.
danieleades
force-pushed
the
installer-test
branch
2 times, most recently
from
07dc38f to
50937be
Compare
danieleades
force-pushed
the
installer-test
branch
from
50937be to
02d4b45
Compare
that should be done now. now there's just the remaining issue of the fact the install script fails on mac-os and windows. i guess the instructions are somewhat linux flavoured |
| name: Installer Test | ||
|
|
||
| on: | ||
| push: |
There was a problem hiding this comment.
it's still on push rather than as a daily job
There was a problem hiding this comment.
What's the rationale for not wanting this on push?
There was a problem hiding this comment.
slows down ci for rare changes. i suppose if you want to add a gate that says only run this if the install script changed, it can be on push, but even then it'd have to be grouped under "ci" workflow to avoid the extra noise
2 participants
the installer currently fails on windows. This PR adds a job which tests the installer against different targets.
This doesn't fix the breakage, but should catch it next time.