Update ZzzOpenData.cpp

[dracy21]

Now, when OpenMonsterModel(153) appears, in MuError.log it will be replaced with the monster's actual name from the enum (SPIDER_EGGS_1, ICE_GIANT, etc.), making the logs much easier to read. 🚀

default: return L"UNKNOWN";

[gemini-code-assist]

Summary of Changes

Hello @dracy21, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the readability of application logs by replacing cryptic numeric monster model identifiers with their descriptive names. This change makes debugging and monitoring much more intuitive, alongside some minor code cleanup and formatting improvements.

Highlights

• Improved Logging: Introduced a new helper function, GetMonsterModelName, which maps EMonsterModelType enum values to their corresponding human-readable wide string names (e.g., ICE_GIANT, SPIDER_EGGS_1).
• Log Readability Enhancement: Modified the OpenMonsterModel function to utilize the new GetMonsterModelName function. This change ensures that the MuError.log now displays descriptive monster names instead of raw numeric IDs when a monster model is opened, significantly improving log clarity and debugging.
• Code Cleanup: Removed the previously empty and unused OpenMonsterModels function, contributing to overall code cleanliness and reducing unnecessary code.
• File Formatting: Applied minor formatting adjustments to the file, including the removal of a Byte Order Mark (BOM) and ensuring consistent newline characters at the end of the file.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request updates the logging of monster model types in OpenMonsterModel to use the actual monster name instead of the enum value. This improves the readability of the logs. The code introduces a new function GetMonsterModelName to map the enum to a string representation.

[gemini-code-assist]

This function has a very long switch statement. Consider using a std::map or std::unordered_map to map EMonsterModelType to the corresponding wchar_t*. This would improve readability and maintainability, especially as the number of monster types grows. Also, consider using constexpr if the compiler supports it.

const wchar_t* GetMonsterModelName(EMonsterModelType Type) {
    static const std::unordered_map<EMonsterModelType, const wchar_t*> monsterNames = {
        {MONSTER_MODEL_ICE_GIANT, L"ICE_GIANT"},
        {MONSTER_MODEL_BUDGE_DRAGON, L"BUDGE_DRAGON"},
        {MONSTER_MODEL_LARVA, L"LARVA"},
        {MONSTER_MODEL_HELL_SPIDER, L"HELL_SPIDER"},
        {MONSTER_MODEL_SPIDER, L"SPIDER"},
        {MONSTER_MODEL_CYCLOPS, L"CYCLOPS"},
        {MONSTER_MODEL_YETI, L"YETI"},
        {MONSTER_MODEL_ELITE_YETI, L"ELITE_YETI"},
        {MONSTER_MODEL_WORM, L"WORM"},
        {MONSTER_MODEL_GOBLIN, L"GOBLIN"},
        {MONSTER_MODEL_CHAIN_SCORPION, L"CHAIN_SCORPION"},
        {MONSTER_MODEL_BEETLE_MONSTER, L"BEETLE_MONSTER"},
        {MONSTER_MODEL_SHADOW, L"SHADOW"},
        {MONSTER_MODEL_TITAN, L"TITAN"},
        {MONSTER_MODEL_GOLDEN_WHEEL, L"GOLDEN_WHEEL"},
        {MONSTER_MODEL_TANTALLOS, L"TANTALLOS"},
        {MONSTER_MODEL_BEAM_KNIGHT, L"BEAM_KNIGHT"},
        {MONSTER_MODEL_DEATH_ANGEL, L"DEATH_ANGEL"},
        {MONSTER_MODEL_ILLUSION_OF_KUNDUN, L"ILLUSION_OF_KUNDUN"},
        {MONSTER_MODEL_AEGIS, L"AEGIS"},
        {MONSTER_MODEL_DEATH_CENTURION, L"DEATH_CENTURION"},
        {MONSTER_MODEL_SHRIKER, L"SHRIKER"},
        {MONSTER_MODEL_CHAOSCASTLE_KNIGHT, L"CHAOSCASTLE_KNIGHT"},
        {MONSTER_MODEL_CHAOSCASTLE_ELF, L"CHAOSCASTLE_ELF"},
        {MONSTER_MODEL_CHAOSCASTLE_WIZARD, L"CHAOSCASTLE_WIZARD"},
        {MONSTER_MODEL_BALGASS, L"BALGASS"},
        {MONSTER_MODEL_SORAM, L"SORAM"},
        {MONSTER_MODEL_DARK_ELF_1, L"DARK_ELF_1"},
        {MONSTER_MODEL_BALLISTA, L"BALLISTA"},
        {MONSTER_MODEL_WITCH_QUEEN, L"WITCH_QUEEN"},
        {MONSTER_MODEL_GOLDEN_STONE_GOLEM, L"GOLDEN_STONE_GOLEM"},
        {MONSTER_MODEL_DEATH_RIDER, L"DEATH_RIDER"},
        {MONSTER_MODEL_DEATH_TREE, L"DEATH_TREE"},
        {MONSTER_MODEL_HELL_MAINE, L"HELL_MAINE"},
        {MONSTER_MODEL_BERSERK, L"BERSERK"},
        {MONSTER_MODEL_SPLINTER_WOLF, L"SPLINTER_WOLF"},
        {MONSTER_MODEL_IRON_RIDER, L"IRON_RIDER"},
        {MONSTER_MODEL_SATYROS, L"SATYROS"},
        {MONSTER_MODEL_BLADE_HUNTER, L"BLADE_HUNTER"},
        {MONSTER_MODEL_KENTAUROS, L"KENTAUROS"},
        {MONSTER_MODEL_GIGANTIS, L"GIGANTIS"},
        {MONSTER_MODEL_GENOCIDER, L"GENOCIDER"},
        {MONSTER_MODEL_PERSONA, L"PERSONA"},
        {MONSTER_MODEL_TWIN_TAIL, L"TWIN_TAIL"},
        {MONSTER_MODEL_DREADFEAR, L"DREADFEAR"},
        {MONSTER_MODEL_DARK_SKULL_SOLDIER_5, L"DARK_SKULL_SOLDIER_5"},
        {MONSTER_MODEL_MAYA_HAND_LEFT, L"MAYA_HAND_LEFT"},
        {MONSTER_MODEL_MAYA_HAND_RIGHT, L"MAYA_HAND_RIGHT"},
        {MONSTER_MODEL_MAYA, L"MAYA"},
        {MONSTER_MODEL_POUCH_OF_BLESSING, L"POUCH_OF_BLESSING"},
        {MONSTER_MODEL_LUNAR_RABBIT, L"LUNAR_RABBIT"},
        {MONSTER_MODEL_FIRE_FLAME_GHOST, L"FIRE_FLAME_GHOST"},
        {MONSTER_MODEL_ZOMBIE_FIGHTER, L"ZOMBIE_FIGHTER"},
        {MONSTER_MODEL_GLADIATOR, L"GLADIATOR"},
        {MONSTER_MODEL_SLAUGTHERER, L"SLAUGTHERER"},
        {MONSTER_MODEL_BLOOD_ASSASSIN, L"BLOOD_ASSASSIN"},
        {MONSTER_MODEL_CRUEL_BLOOD_ASSASSIN, L"CRUEL_BLOOD_ASSASSIN"},
        {MONSTER_MODEL_LAVA_GIANT, L"LAVA_GIANT"},
        {MONSTER_MODEL_BURNING_LAVA_GIANT, L"BURNING_LAVA_GIANT"},
        {MONSTER_MODEL_RABBIT, L"RABBIT"},
        {MONSTER_MODEL_BUTTERFLY, L"BUTTERFLY"},
        {MONSTER_MODEL_HIDEOUS_RABBIT, L"HIDEOUS_RABBIT"},
        {MONSTER_MODEL_WEREWOLF2, L"WEREWOLF2"},
        {MONSTER_MODEL_CURSED_LICH, L"CURSED_LICH"},
        {MONSTER_MODEL_TOTEM_GOLEM, L"TOTEM_GOLEM"},
        {MONSTER_MODEL_GRIZZLY, L"GRIZZLY"},
        {MONSTER_MODEL_CAPTAIN_GRIZZLY, L"CAPTAIN_GRIZZLY"},
        {MONSTER_MODEL_SAPIUNUS, L"SAPIUNUS"},
        {MONSTER_MODEL_SAPIDUO, L"SAPIDUO"},
        {MONSTER_MODEL_SAPITRES, L"SAPITRES"},
        {MONSTER_MODEL_SHADOW_PAWN, L"SHADOW_PAWN"},
        {MONSTER_MODEL_SHADOW_KNIGHT, L"SHADOW_KNIGHT"},
        {MONSTER_MODEL_SHADOW_LOOK, L"SHADOW_LOOK"},
        {MONSTER_MODEL_NAPIN, L"NAPIN"},
        {MONSTER_MODEL_GHOST_NAPIN, L"GHOST_NAPIN"},
        {MONSTER_MODEL_BLAZE_NAPIN, L"BLAZE_NAPIN"},
        {MONSTER_MODEL_ICE_WALKER, L"ICE_WALKER"},
        {MONSTER_MODEL_GIANT_MAMMOTH, L"GIANT_MAMMOTH"},
        {MONSTER_MODEL_COOLUTIN, L"COOLUTIN"},
        {MONSTER_MODEL_IRON_KNIGHT, L"IRON_KNIGHT"},
        {MONSTER_MODEL_SELUPAN, L"SELUPAN"},
        {MONSTER_MODEL_SPIDER_EGGS_1, L"SPIDER_EGGS_1"},
        {MONSTER_MODEL_SPIDER_EGGS_2, L"SPIDER_EGGS_2"},
        {MONSTER_MODEL_SPIDER_EGGS_3, L"SPIDER_EGGS_3"},
        {MONSTER_MODEL_CURSED_SANTA, L"CURSED_SANTA"},
        {MONSTER_MODEL_GAYION, L"GAYION"},
        {MONSTER_MODEL_JERRY, L"JERRY"},
        {MONSTER_MODEL_RAYMOND, L"RAYMOND"},
        {MONSTER_MODEL_LUCAS, L"LUCAS"},
        {MONSTER_MODEL_FRED, L"FRED"},
        {MONSTER_MODEL_HAMMERIZE, L"HAMMERIZE"},
        {MONSTER_MODEL_DUAL_BERSERKER, L"DUAL_BERSERKER"},
        {MONSTER_MODEL_DEVIL_LORD, L"DEVIL_LORD"},
        {MONSTER_MODEL_QUARTER_MASTER, L"QUARTER_MASTER"},
        {MONSTER_MODEL_COMBAT_INSTRUCTOR, L"COMBAT_INSTRUCTOR"},
        {MONSTER_MODEL_ATICLES_HEAD, L"ATICLES_HEAD"},
        {MONSTER_MODEL_DARK_GHOST, L"DARK_GHOST"},
        {MONSTER_MODEL_BANSHEE, L"BANSHEE"},
        {MONSTER_MODEL_HEAD_MOUNTER, L"HEAD_MOUNTER"},
        {MONSTER_MODEL_DEFENDER, L"DEFENDER"},
        {MONSTER_MODEL_OCELOT, L"OCELOT"},
        {MONSTER_MODEL_ERIC, L"ERIC"},
        {MONSTER_MODEL_MAD_BUTCHER, L"MAD_BUTCHER"},
        {MONSTER_MODEL_TERRIBLE_BUTCHER, L"TERRIBLE_BUTCHER"},
        {MONSTER_MODEL_DOPPELGANGER, L"DOPPELGANGER"},
        {MONSTER_MODEL_MEDUSA, L"MEDUSA"},
        {MONSTER_MODEL_DARK_MAMMOTH, L"DARK_MAMMOTH"},
        {MONSTER_MODEL_DARK_GIANT, L"DARK_GIANT"},
        {MONSTER_MODEL_DARK_COOLUTIN, L"DARK_COOLUTIN"},
        {MONSTER_MODEL_DARK_IRON_KNIGHT, L"DARK_IRON_KNIGHT"},
        {MONSTER_MODEL_BLOODY_ORC, L"BLOODY_ORC"},
        {MONSTER_MODEL_BLOODY_DEATH_RIDER, L"BLOODY_DEATH_RIDER"},
        {MONSTER_MODEL_BLOODY_GOLEM, L"BLOODY_GOLEM"},
        {MONSTER_MODEL_BLOODY_WITCH_QUEEN, L"BLOODY_WITCH_QUEEN"},
        {MONSTER_MODEL_SAPI_QUEEN, L"SAPI_QUEEN"},
        {MONSTER_MODEL_ICE_NAPIN, L"ICE_NAPIN"},
        {MONSTER_MODEL_SHADOW_MASTER, L"SHADOW_MASTER"},
        {MONSTER_MODEL_BERSERKER_WARRIOR, L"BERSERKER_WARRIOR"},
        {MONSTER_MODEL_KENTAUROS_WARRIOR, L"KENTAUROS_WARRIOR"},
        {MONSTER_MODEL_GIGANTIS_WARRIOR, L"GIGANTIS_WARRIOR"},
        {MONSTER_MODEL_SOCCERBALL, L"SOCCERBALL"},
        {MONSTER_MODEL_VENOMOUS_CHAIN_SCORPION, L"VENOMOUS_CHAIN_SCORPION"},
        {MONSTER_MODEL_BONE_SCORPION, L"BONE_SCORPION"},
        {MONSTER_MODEL_ORCUS, L"ORCUS"},
        {MONSTER_MODEL_GOLLOCK, L"GOLLOCK"},
        {MONSTER_MODEL_CRYPTA, L"CRYPTA"},
        {MONSTER_MODEL_CRYPOS, L"CRYPOS"},
        {MONSTER_MODEL_CONDRA, L"CONDRA"},
        {MONSTER_MODEL_NACONDRA, L"NACONDRA"}
    };

    auto it = monsterNames.find(Type);
    if (it != monsterNames.end()) {
        return it->second;
    } else {
        return L"UNKNOWN";
    }
}

[sven-n]

Hi, thanks, that's a good idea. However, it has two points for improvement IMHO:

1. It's incomplete, not all model names are mapped.
2. Instead "UNKNOWN", we could still print out the Type value.

And just a hint... It's hard to extend - if someone wants to add new models, he'd have to think of this place, too. However, this main source is full of suboptimal stuff, so this doesn't matter anyway 😅

[dracy21]

Yeah, I know what you mean — it was annoying that you couldn’t understand anything.
You're right about the Type instead of just the mob number. I'll take care of that when I have time.

Hi, thanks, that's a good idea. However, it has two points for improvement IMHO:

1. It's incomplete, not all model names are mapped.

2. Instead "UNKNOWN", we could still print out the `Type` value.

And just a hint... It's hard to extend - if someone wants to add new models, he'd have to think of this place, too. However, this main source is full of suboptimal stuff, so this doesn't matter anyway 😅

Yeah, I know what you mean — it was annoying that you couldn’t understand anything.
You're right about the Type instead of just the mob number. I'll take care of that when I have time.

[sven-n]

Btw, I hope you didn't type that all by hand, because with Regex it's done in a minute 😅
Example: https://regex101.com/r/28K3Hc/1
Regex: (MONSTER_MODEL_)([\w_]*)\s*=\s*\d+.
Replace by: case $1$2: return L"$2";