-
-
Notifications
You must be signed in to change notification settings - Fork 1k
chore: Update to dotnet 10 #2888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4ead573
5df3988
6e52c0a
68fe6d3
1b18665
a096273
dbf21d2
9715074
f930ef8
e09d790
4f46250
44db3e8
e9c6ae6
7bf49b2
b022f4e
6f1f3ea
cac9c04
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Eideren marked this conversation as resolved.
Show resolved
Hide resolved
|
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should also migrate to the In addition, having the solution files in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Kind of out of the scope of this one, let's get this in and migrate afterwards I think. On top of that, I barely looked at these new features so I would rather avoid taking care of it until I am more familiar with that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trailing
\might make this command fail.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing
\is actually ok. Already tested. This GitHub Action fails because of Windows (Game Studio) dependencies. This GitHub Action, or the project it is referencing needs to be updated, so the project doesn't reference Windows references because this actions runs on Linux runner.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow isn't supposed to work yet (on
master). It was added as a convenience so that we can target other branches, especially one where work on Linux build is being done. It is not called from the main workflow at the moment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I saw that. I tried to fix it for .NET 10 and realised those references and that most likely it is unfinished. Thanks for a confirmation. We can leave it then till the right time comes later on. I was able to fix at least some parts which should help to run this actions once it is finalised/fixed/corrected.