-
-
Notifications
You must be signed in to change notification settings - Fork 1k
chore: Update to dotnet 10 #2888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Issue 1 resolved. Thanks. |
Third one is fixed through #2893 |
Thanks, I will try to test it all. |
Tested all above (I didn't test all samples/tutorials/templates), and it seems to be fixed, well this below is the full error when FirstPersonShooter is upgraded from
|
@VaclavElias It is not, FastList is marked as obsolete, the error is about an interface method that changed from |
* ci: Replace dotnet CLI with msbuild in workflows - Added `global.json` to specify .NET SDK version `10.0.100` with `rollForward` set to `latestMinor` for compatibility and flexibility. * fix: .NET SDK version updated * fix: ios workload added * fix: android workflow added * feat: Setup Android NDK added and NDK enviroment configuration * test: GitHub actions updated for Android * fix: android-sdk path explicitly added * test: Remove NDK 26.3 * test: Reversing the change * refactor: Simplifying workflow * test: Disabling android workload, probaly it isn't needed * fix: android workflow re-enabled * ci: Improve Linux compatibility in build and test scripts - Updated `dotnet build` and `dotnet test` commands to use forward slashes (`/`) instead of backslashes (`\`) for file paths and line continuations, ensuring compatibility with Linux systems. * feat: Install Build Dependencies step added * fix: Make strlcat_chk and strlcpy_chk non-fatal on Linux * feat: llvm added * feat: lld added * feat: Create NuGet.config added * test: Testing another approach * fix: Action updated * fix: Updates reversed * test: Path test added * test: Configure NuGet Sources added * fix: Semicolon replaced * fix: Paths corrected * test: Additinal updates * fix: Action updated * text: Projects from editor folder removed * test: Custom source disabled * test: Removing Windows specific tests * ci: Clean up * ci: Removig a comment * fix: Reversing the changes back
@VaclavElias having a global.json just for github's CI isn't great from a maintenance standpoint, I'm guessing it is required ? |
These failes are actually ok and expected. The tests are failing because the old (.NET 8) GitHub Actions are run from the master branch on your .NET 10 changes. The new GitHub Actions you merged aren't run. They can be run only if:
Regarding |
Right, forgot about that part ! |
Ok, I will do a follow up PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few remarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also migrate to the .slnx
file instead of the old .sln
, though I don't know how that will work with ReSharper/Rider, as well as filtered solutions (.slnf
).
In addition, having the solution files in the build
folder always felt wrong to me. I think we should move the main one (Stride.sln
) to the sources
folder. Filtered solutions could stay there, and old Stride.xxx.sln
should be replaced by filtered solutions (that means the Launcher should be part of the main solution).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of out of the scope of this one, let's get this in and migrate afterwards I think. On top of that, I barely looked at these new features so I would rather avoid taking care of it until I am more familiar with that.
-v:m -p:WarningLevel=0 \ | ||
-p:Configuration=${{ github.event.inputs.build-type || inputs.build-type }} \ | ||
-p:StridePlatforms=Linux \ | ||
-p:StrideGraphicsApis=OpenGL \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trailing \
might make this command fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing \
is actually ok. Already tested. This GitHub Action fails because of Windows (Game Studio) dependencies. This GitHub Action, or the project it is referencing needs to be updated, so the project doesn't reference Windows references because this actions runs on Linux runner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow isn't supposed to work yet (on master
). It was added as a convenience so that we can target other branches, especially one where work on Linux build is being done. It is not called from the main workflow at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I saw that. I tried to fix it for .NET 10 and realised those references and that most likely it is unfinished. Thanks for a confirmation. We can leave it then till the right time comes later on. I was able to fix at least some parts which should help to run this actions once it is finalised/fixed/corrected.
<StrideCompileAssetCommand Condition="'$(StrideCompileAssetCommand)' == '' And Exists('$(MSBuildThisFileDirectory)..\lib\net8.0-windows7.0\') And $(TargetFramework.Contains('-windows'))">$(MSBuildThisFileDirectory)..\lib\net8.0-windows7.0\Stride.Core.Assets.CompilerApp.dll</StrideCompileAssetCommand> | ||
<StrideCompileAssetCommand Condition="'$(StrideCompileAssetCommand)' == '' And Exists('$(MSBuildThisFileDirectory)..\lib\net8.0\')">$(MSBuildThisFileDirectory)..\lib\net8.0\Stride.Core.Assets.CompilerApp.dll</StrideCompileAssetCommand> | ||
<StrideCompileAssetCommand Condition="'$(StrideCompileAssetCommand)' == '' And Exists('$(MSBuildThisFileDirectory)..\Stride.Core.Assets.CompilerApp.csproj')">$(MSBuildThisFileDirectory)..\bin\$(Configuration)\net8.0\Stride.Core.Assets.CompilerApp.dll</StrideCompileAssetCommand> | ||
<StrideCompileAssetCommand Condition="'$(StrideCompileAssetCommand)' == '' And Exists('$(MSBuildThisFileDirectory)..\lib\net10.0-windows7.0\') And $(TargetFramework.Contains('-windows'))">$(MSBuildThisFileDirectory)..\lib\net10.0-windows7.0\Stride.Core.Assets.CompilerApp.dll</StrideCompileAssetCommand> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the -windows7.0
suffix still valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation hasn't been updated to net10, but 9 did still use 7.0 as the default os version value https://learn.microsoft.com/en-us/dotnet/standard/frameworks
And building Stride.Samples.Templates
does produce a nuget package containing a directory with path \lib\net10.0-windows7.0
...ces/engine/Stride.BepuPhysics/Stride.BepuPhysics/Definitions/Colliders/ConvexHullCollider.cs
Show resolved
Hide resolved
@Eideren I tried to push to your branch, but somehow it doesn't work even though you enabled You can cherry-pick this commit which should make most build work: Kryptos-FR/stride@206df68 |
@Kryptos-FR had an issue with that feature as well , you'll have to remove the deprecated lfs hook in your |
@Eideren I already did that. It's a different error. It tells me I don't have the rights to push. Could be a settings on your repo maybe. It worked fine for another PR where I could push a new commit. |
I don't have anything on my end to control that as far as I can tell - In any case, your change has been cherry-picked, so if there's nothing else I think we can go ahead and merge |
Looks like
|
PR Details
Given that it's a bit early for net 10, some of the readme links don't map to anything yet, for example the build tools do not exist yet. Still, I built it from Rider using the msbuild vs2026 comes with, just not too sure what we should do in that regard.
Also need to update TeamCity before merging this inRelated Issue
Types of changes
Checklist