Skip to content

Conversation

Gali-StarkWare
Copy link
Contributor

No description provided.

Copy link
Contributor Author

Gali-StarkWare commented Apr 29, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.73%. Comparing base (554d206) to head (a598ccf).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           gali/parallel_barycentric    #1073   +/-   ##
==========================================================
  Coverage                      92.73%   92.73%           
==========================================================
  Files                            106      106           
  Lines                          14568    14568           
  Branches                       14568    14568           
==========================================================
  Hits                           13510    13510           
  Misses                           977      977           
  Partials                          81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gali-StarkWare Gali-StarkWare force-pushed the gali/parallel_barycentric branch 2 times, most recently from 1ff75ed to 8daa3b4 Compare April 29, 2025 14:31
@Gali-StarkWare Gali-StarkWare force-pushed the gali/parallel_barycentric branch from 8daa3b4 to 57745f8 Compare May 14, 2025 08:03
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 4ac4b3f Previous: fbb2d92 Ratio
iffts/simd ifft/22 12650127 ns/iter (± 148352) 6130911 ns/iter (± 33655) 2.06
iffts/simd ifft/26 264049657 ns/iter (± 1807915) 126855348 ns/iter (± 1195167) 2.08
iffts/simd ifft/27 623932282 ns/iter (± 14906129) 274744279 ns/iter (± 4105570) 2.27
iffts/simd ifft/28 1318219964 ns/iter (± 65145549) 579959239 ns/iter (± 11089640) 2.27
merkle throughput/simd merkle 31489765 ns/iter (± 453365) 13850340 ns/iter (± 199054) 2.27
simd quotients 2^8 x 2^20 484430198 ns/iter (± 5016484) 231172647 ns/iter (± 3839194) 2.10

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

@Gali-StarkWare Gali-StarkWare changed the base branch from gali/parallel_barycentric to graphite-base/1073 May 25, 2025 14:14
@Gali-StarkWare Gali-StarkWare changed the base branch from graphite-base/1073 to gali/parallel_barycentric May 25, 2025 14:20
@Gali-StarkWare Gali-StarkWare changed the base branch from gali/parallel_barycentric to graphite-base/1073 May 28, 2025 09:25
@Gali-StarkWare Gali-StarkWare changed the base branch from graphite-base/1073 to gali/parallel_barycentric May 28, 2025 14:26
@Gali-StarkWare Gali-StarkWare marked this pull request as ready for review May 28, 2025 14:31
@Gali-StarkWare Gali-StarkWare force-pushed the gali/parallel_barycentric branch from c95cb64 to f37305f Compare June 9, 2025 09:53
@Gali-StarkWare Gali-StarkWare force-pushed the gali/parallel_barycentric branch from f37305f to 554d206 Compare June 9, 2025 09:57
@Gali-StarkWare Gali-StarkWare force-pushed the gali/parallel_barycentric branch from 554d206 to 0173dd1 Compare June 9, 2025 10:00
@Gali-StarkWare Gali-StarkWare changed the base branch from gali/parallel_barycentric to graphite-base/1073 June 11, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants