Skip to content

Conversation

Gali-StarkWare
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

Gali-StarkWare commented Apr 29, 2025

@Gali-StarkWare Gali-StarkWare force-pushed the gali/barycentric_in_polyops branch from 5f098cc to 9c44f04 Compare April 29, 2025 14:26
@Gali-StarkWare Gali-StarkWare force-pushed the gali/weights_in_bit_reverse_order branch from 03c8ab1 to b31d7bd Compare April 29, 2025 14:26
@Gali-StarkWare Gali-StarkWare force-pushed the gali/weights_in_bit_reverse_order branch from b31d7bd to c716759 Compare May 14, 2025 08:03
@Gali-StarkWare Gali-StarkWare force-pushed the gali/barycentric_in_polyops branch from 9c44f04 to 5a792e4 Compare May 14, 2025 08:03
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: d46e33e Previous: d82fc0d Ratio
iffts/simd ifft/27 569146336 ns/iter (± 5313880) 268005817 ns/iter (± 7372585) 2.12
iffts/simd ifft/28 1210877982 ns/iter (± 22379981) 546374837 ns/iter (± 14302025) 2.22
merkle throughput/simd merkle 27898353 ns/iter (± 1121972) 12957990 ns/iter (± 271026) 2.15

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

@Gali-StarkWare Gali-StarkWare changed the base branch from gali/barycentric_in_polyops to graphite-base/1071 May 25, 2025 14:12
@Gali-StarkWare Gali-StarkWare changed the base branch from graphite-base/1071 to gali/barycentric_in_polyops May 25, 2025 14:20
@Gali-StarkWare Gali-StarkWare changed the base branch from gali/barycentric_in_polyops to graphite-base/1071 May 28, 2025 08:49
@Gali-StarkWare Gali-StarkWare force-pushed the gali/weights_in_bit_reverse_order branch from c716759 to 7d02994 Compare May 28, 2025 09:26
@Gali-StarkWare Gali-StarkWare changed the base branch from graphite-base/1071 to gali/barycentric_in_polyops May 28, 2025 09:26
@Gali-StarkWare Gali-StarkWare marked this pull request as ready for review May 28, 2025 09:26
@Gali-StarkWare Gali-StarkWare self-assigned this May 28, 2025
@Gali-StarkWare Gali-StarkWare force-pushed the gali/weights_in_bit_reverse_order branch from 7d02994 to d99370d Compare May 28, 2025 14:26
@Gali-StarkWare Gali-StarkWare force-pushed the gali/weights_in_bit_reverse_order branch from d99370d to d82fc0d Compare June 9, 2025 09:53
@Gali-StarkWare Gali-StarkWare force-pushed the gali/barycentric_in_polyops branch from e5af4b3 to e5ca27c Compare June 9, 2025 09:53
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.71%. Comparing base (e5ca27c) to head (d82fc0d).

Additional details and impacted files
@@                       Coverage Diff                       @@
##           gali/barycentric_in_polyops    #1071      +/-   ##
===============================================================
- Coverage                        92.71%   92.71%   -0.01%     
===============================================================
  Files                              106      106              
  Lines                            14530    14529       -1     
  Branches                         14530    14529       -1     
===============================================================
- Hits                             13472    13471       -1     
  Misses                             977      977              
  Partials                            81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gali-StarkWare Gali-StarkWare force-pushed the gali/barycentric_in_polyops branch 2 times, most recently from 98d1ff3 to 968ea2f Compare June 9, 2025 09:56
@Gali-StarkWare Gali-StarkWare force-pushed the gali/weights_in_bit_reverse_order branch from d82fc0d to 30ad653 Compare June 9, 2025 09:56
@Gali-StarkWare Gali-StarkWare force-pushed the gali/weights_in_bit_reverse_order branch from 30ad653 to d46e33e Compare June 9, 2025 10:00
@Gali-StarkWare Gali-StarkWare changed the base branch from gali/barycentric_in_polyops to graphite-base/1071 June 9, 2025 10:17
@Gali-StarkWare Gali-StarkWare changed the base branch from graphite-base/1071 to gali/barycentric_in_polyops June 9, 2025 10:21
@Gali-StarkWare Gali-StarkWare changed the base branch from gali/barycentric_in_polyops to graphite-base/1071 June 11, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants