Skip to content

Conversation

@arad-starkware
Copy link
Collaborator

@arad-starkware arad-starkware commented Nov 19, 2025

This change is Reviewable


Note

Adds a flow test asserting get_stakers returns 100% staking power with BTC delegation and exposes STAKING_POWER_BASE_VALUE for use.

  • Tests:
    • Add get_stakers_staking_power_100_flow_test in src/flow_test/test.cairo to verify staking power equals STAKING_POWER_BASE_VALUE when delegating BTC to a single staker.
  • Utils:
    • Make STAKING_POWER_BASE_VALUE pub(crate) in src/staking/utils.cairo and import it in tests.

Written by Cursor Bugbot for commit 21f569c. This will update automatically on new commits. Configure here.

@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_100_power_test branch from 7881500 to e12b29c Compare November 19, 2025 13:36
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_switch_flow branch from 044ec48 to 10b3104 Compare November 19, 2025 13:39
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_100_power_test branch from e12b29c to d83eb46 Compare November 19, 2025 13:39
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_switch_flow branch from 10b3104 to 896b20e Compare November 19, 2025 13:41
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_100_power_test branch 2 times, most recently from be8a081 to c3f3f6c Compare November 19, 2025 13:48
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_switch_flow branch from 896b20e to be214f3 Compare November 19, 2025 13:48
Copy link
Collaborator

@noa-starkware noa-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @arad-starkware)

@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_switch_flow branch from be214f3 to 1bb31ed Compare November 19, 2025 14:15
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_100_power_test branch from c3f3f6c to 0f39038 Compare November 19, 2025 14:15
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_switch_flow branch from 1bb31ed to c37d705 Compare November 19, 2025 14:27
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_100_power_test branch from 0f39038 to d613a10 Compare November 19, 2025 14:28
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_switch_flow branch from c37d705 to b4bf2cf Compare November 19, 2025 14:29
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_100_power_test branch 2 times, most recently from 74c6363 to 899085f Compare November 20, 2025 08:15
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_switch_flow branch 2 times, most recently from 4cd417a to 2337137 Compare November 20, 2025 08:17
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_100_power_test branch from 899085f to 879be2f Compare November 20, 2025 08:17
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_100_power_test branch from 574f56b to 1f544a7 Compare November 20, 2025 08:32
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_switch_flow branch from 9da15c6 to 88f4f8b Compare November 20, 2025 09:40
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_100_power_test branch 2 times, most recently from 8778016 to e85d913 Compare November 20, 2025 09:50
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_switch_flow branch 2 times, most recently from 928b0df to 2e3484c Compare November 20, 2025 11:03
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_100_power_test branch from e85d913 to e1d0bae Compare November 20, 2025 11:04
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_switch_flow branch from 2e3484c to 8eac940 Compare November 20, 2025 11:07
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_100_power_test branch from e1d0bae to 7fd199b Compare November 20, 2025 11:08
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_switch_flow branch 2 times, most recently from 6f24aa1 to 003bd3c Compare November 20, 2025 11:13
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_100_power_test branch from 7fd199b to 8742caa Compare November 20, 2025 11:14
@arad-starkware arad-starkware changed the base branch from arad/test_add_get_stakers_switch_flow to graphite-base/34 November 20, 2025 11:19
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_100_power_test branch from 8742caa to 93429b1 Compare November 20, 2025 11:19
@graphite-app graphite-app bot changed the base branch from graphite-base/34 to main November 20, 2025 11:20
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_100_power_test branch from 93429b1 to 6e75484 Compare November 20, 2025 11:20
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.54%. Comparing base (a28d60e) to head (21f569c).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   95.43%   95.54%   +0.10%     
==========================================
  Files          45       45              
  Lines        9446     9673     +227     
==========================================
+ Hits         9015     9242     +227     
  Misses        431      431              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_100_power_test branch from 6e75484 to 0730902 Compare November 20, 2025 11:28
Copy link
Collaborator Author

arad-starkware commented Nov 20, 2025

Merge activity

  • Nov 20, 11:33 AM UTC: Graphite couldn't merge this PR because it failed for an unknown reason (This repository has GitHub's merge queue enabled. Please configure the GitHub merge queue integration in Graphite settings.).
  • Nov 20, 1:55 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Nov 20, 1:59 PM UTC: @arad-starkware merged this pull request with Graphite.

@arad-starkware arad-starkware added this pull request to the merge queue Nov 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 20, 2025
@arad-starkware arad-starkware added this pull request to the merge queue Nov 20, 2025
@arad-starkware arad-starkware enabled auto-merge (squash) November 20, 2025 13:53
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_100_power_test branch from 0730902 to c0d8b94 Compare November 20, 2025 13:55
@arad-starkware arad-starkware force-pushed the arad/test_add_get_stakers_100_power_test branch from c0d8b94 to 21f569c Compare November 20, 2025 13:55
@arad-starkware arad-starkware merged commit db61e91 into main Nov 20, 2025
6 of 7 checks passed
@arad-starkware arad-starkware deleted the arad/test_add_get_stakers_100_power_test branch November 20, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants