-
Notifications
You must be signed in to change notification settings - Fork 41
test: add get_stakers with zero balance flow #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add get_stakers with zero balance flow #26
Conversation
28e5e23 to
8622540
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
- Coverage 95.74% 95.39% -0.35%
==========================================
Files 47 45 -2
Lines 11159 9362 -1797
==========================================
- Hits 10684 8931 -1753
+ Misses 475 431 -44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8622540 to
bf7e058
Compare
noa-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noa-starkware reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @NirLevi-starkware)
workspace/apps/staking/contracts/src/flow_test/test.cairo line 1890 at r2 (raw file):
let staking_consensus = system.staking.consensus_dispatcher(); // Test balance with get_stakers
Suggestion:
Test same epoch.
arad-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @NirLevi-starkware)
workspace/apps/staking/contracts/src/flow_test/test.cairo line 1890 at r2 (raw file):
let staking_consensus = system.staking.consensus_dispatcher(); // Test balance with get_stakers
Done
bf7e058 to
82c2b26
Compare
noa-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @NirLevi-starkware)

This change is
Note
Adds a flow test for
get_stakersvalidating zero-balance/new staker visibility across epochs and updates the flow ideas doc.get_stakers_zero_balance_flow_testinworkspace/apps/staking/contracts/src/flow_test/test.cairoto validateget_stakersreturns:STRK_WEIGHT_FACTORandOption::Nonepublic key starting the following epoch, persisting thereafter.flow_ideas.mdunderget_stakersby removing the zero-balance case entry.Written by Cursor Bugbot for commit 82c2b26. This will update automatically on new commits. Configure here.