Keeping SyntaxNode parent's data id for optimizations

[eytan-starkware]

TL;DR

Optimize SyntaxNode parent lookups by caching parent data to reduce database queries.

What changed?

• Modified SyntaxNode to cache parent data, avoiding repeated database lookups
• Added new helper methods like is_root() and grandparent() to improve code readability
• Optimized nth_parent() to use cached parent data when possible
• Improved parent-related lookups in various methods like file_id(), parent_kind().
• Replaced multiple chained parent(db) calls with more efficient alternatives throughout the codebase

[reviewable-StarkWare]

This change is 

[eytan-starkware]

• Keeping SyntaNode's kind and parent kind for optimization #8515 : 2 dependent PRs (#8527 , #8578 )
• Keeping SyntaxNode parent's data id for optimizations #8513 👈 (View in Graphite)
• Making Stable Syntax Pointers just a wrapper around syntax nodes #8501 : 1 other dependent PR (#8507 )
• Tracking SyntaxNode and interning through a tracked function #8489
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[TomerStarkware]

@TomerStarkware reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)

[orizi]

@orizi reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eytan-starkware)

---

crates/cairo-lang-syntax/src/node/mod.rs line 188 at r1 (raw file):

            ptr = ptr.and_then(|p| p.parent(db));
        }
        ptr.unwrap_or_else(|| {

Suggestion:

        let mut result = Some(*self);
        while let Some(p) = result && n > 1 {
            result = p.grandparent(db);
            n -= 2;
        }
        if let Some(p) = result && n == 1 {
            result = p.parent(db);
        }
        result.unwrap_or_else(|| {

[eytan-starkware]

Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @orizi and @TomerStarkware)

---

crates/cairo-lang-syntax/src/node/mod.rs line 188 at r1 (raw file):

            ptr = ptr.and_then(|p| p.parent(db));
        }
        ptr.unwrap_or_else(|| {

Done.

[orizi]

@orizi reviewed 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eytan-starkware)

[orizi]

@orizi reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eytan-starkware)

[graphite-app]

Merge activity

• Oct 28, 2:19 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.