Making Stable Syntax Pointers just a wrapper around syntax nodes

[eytan-starkware]

Optimize Syntax Node Representation for Better Performance

TL;DR

Refactored the syntax node representation to eliminate the separate SyntaxStablePtr structure, reducing indirection and improving performance.

What changed?

• Replaced the SyntaxStablePtr enum with a direct reference to SyntaxNode
• Embedded key fields and index information directly in the SyntaxNodeData structure
• Modified the node creation and lookup process to use this more efficient representation
• Changed the parent representation to use Either<SyntaxNode, FileId> for clearer root node handling

NOTE
I introduced a semantic change:
Root is now actually a Node of SyntaxFile. This means:
a. parent can return a node that usually would panic
b. kind can return SyntaxFile
c. SyntaxFile key fields can be called

[reviewable-StarkWare]

This change is 

[eytan-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Making Stable Syntax Pointers just a wrapper around syntax nodes #8501 : 2 dependent PRs (#8507 , #8513 ) 👈 (View in Graphite)
• Tracking SyntaxNode and interning through a tracked function #8489
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[orizi]

@orizi reviewed 7 of 10 files at r1, all commit messages.
Reviewable status: 7 of 10 files reviewed, 3 unresolved discussions (waiting on @TomerStarkware)

---

crates/cairo-lang-defs/src/cache/mod.rs line 1569 at r1 (raw file):

}

#[derive(Serialize, Deserialize, Clone, Copy, Hash, Eq, PartialEq, salsa::Update)]

Probably not required - just need to remove the rest.

Suggestion:

#[derive(Serialize, Deserialize, Clone, Copy, Hash, Eq, PartialEq)]

---

crates/cairo-lang-defs/src/cache/mod.rs line 1576 at r1 (raw file):

    green: GreenIdCached,
    offset: TextOffset,
    // TODO(eytan-starkware): Using result for serde implementation. Change this to Either.

add serde for it - or just map to another serde function.

Code quote:

    // TODO(eytan-starkware): Using result for serde implementation. Change this to Either.

---

crates/cairo-lang-syntax/src/node/db.rs line 22 at r1 (raw file):

        offset: TextOffset,
        parent: Either<SyntaxNode<'db>, FileId<'db>>,
        index: usize,

f2f

Code quote:

        parent: Either<SyntaxNode<'db>, FileId<'db>>,
        index: usize,

---

crates/cairo-lang-defs/src/ids.rs line 790 at r1 (raw file):

    pub fn name(&self, db: &'db dyn Database) -> Option<SmolStrId<'db>> {
        let node = self.1.0.0;
        assert!(node.parent(db).is_some());

consider removing these - as these are extra queries not really needed.

Code quote:

        assert!(node.parent(db).is_some());

[orizi]

@orizi reviewed 2 of 10 files at r1.
Reviewable status: 9 of 10 files reviewed, 3 unresolved discussions (waiting on @eytan-starkware and @TomerStarkware)

[eytan-starkware]

Reviewable status: 9 of 10 files reviewed, 3 unresolved discussions (waiting on @orizi and @TomerStarkware)

---

crates/cairo-lang-defs/src/ids.rs line 790 at r1 (raw file):

Previously, orizi wrote…

consider removing these - as these are extra queries not really needed.

Will change to a non query accessor in the future. Added todo.

---

crates/cairo-lang-defs/src/cache/mod.rs line 1569 at r1 (raw file):

Previously, orizi wrote…

Probably not required - just need to remove the rest.

Some salsa::Update implementations are necessary for the loading data context to be salsa::Update. Removed what I could

---

crates/cairo-lang-defs/src/cache/mod.rs line 1576 at r1 (raw file):

Previously, orizi wrote…

add serde for it - or just map to another serde function.

Using my own enum now

---

crates/cairo-lang-syntax/src/node/db.rs line 22 at r1 (raw file):

Previously, orizi wrote…

f2f

Using a new enum for the unique identifier of the syntax node

[TomerStarkware]

@TomerStarkware reviewed 10 of 10 files at r1, 10 of 10 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @orizi)

[orizi]

@orizi reviewed 10 of 10 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eytan-starkware)

[orizi]

@orizi reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eytan-starkware)