Skip to content

Delay file input events until bound signal has updated #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Delay file input events until bound signal has updated #1032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion library/src/plugins/attributes/bind.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,10 @@ export const Bind: AttributePlugin = {
}
break
case 'file': {
const syncSignal = () => {
const syncSignal = (evt: Event) => {
const target = evt.target
if ('detail' in evt || target === null) return
evt.stopImmediatePropagation()
const files = [...(el.files || [])]
const contents: string[] = []
const mimes: string[] = []
Expand Down Expand Up @@ -119,6 +122,7 @@ export const Bind: AttributePlugin = {
},
),
)
target.dispatchEvent(new CustomEvent(evt.type, {detail: true}))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe this should go in a finally so the event doesn't get swallowed in case there is an error reading the files.

})
}

Expand Down