Delay file input events until bound signal has updated #1032
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gazpachoking
commented
Jul 31, 2025
| }, | ||
| ), | ||
| ) | ||
| target.dispatchEvent(new CustomEvent(evt.type, {detail: true})) |
There was a problem hiding this comment.
Hmm, maybe this should go in a finally so the event doesn't get swallowed in case there is an error reading the files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you bind a signal to a file input, and also have a change/input listener on that input, the event handler will get called before the signal has been updated with the new data. From this thread
The following will log 'undefined' the first time the change event is fired, and be one change behind for subsequent events.
This fixes that by stopping the propagation of the event in the bind handler and re-dispatching it once the signal has been updated. Feels hacky though.