Group nodes generated by :kbd: role and add class to separators (#13876)

[brechtm]

See #13876: Regression: :kbd: in Sphinx 8.2

[AA-Turner]

Test failures seem related. Please also add a CHANGES entry.

[brechtm]

Test failures seem related. Please also add a CHANGES entry.

Fixed and done!

Not sure you got notified of my new commits, so here's a friendly nudge 🙂

[AA-Turner]

@brechtm I've updated this so that the wrapper element is only inserted for groups of <kbd> elements, what do you think?

This restores previous behaviour mistakenly removed in #13227, HTML tags previously had .kbd.compound classes.

A

[brechtm]

@brechtm I've updated this so that the wrapper element is only inserted for groups of <kbd> elements, what do you think?

Mmm, this makes things less consistent, I think. The wrapper element could be used to style the entire keyboard shortcut, whether it consists of a single keypress or a combination. Note that the wrapper does not affect the styling of a single <kbd> elements if no style is defined for it.

[AA-Turner]

@brechtm yes, though I'd argue also clearer semantics. A nested <kbd> with only one child key is quite odd, there are no examples of it on MDN.

If your problem is CSS, would it work to adjust the classes in some fashion?

A

[brechtm]

Oops, I was mixing up the docutils doctree and the HTML representation. My primary concern is the rinohtype implementation, of course.

I think it makes sense that the docutils tree for this would consistently have the outer (compound) level, even if there's only a single child element inside. The HTML writer can always remove it when there is only a single child element, even though it could be useful to have the outer <kbd> present at all times there too...