Skip to content

Optimize memory usage by replacing the queue's underlying container with a list. #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 17, 2025
+4 −2
Merged

Optimize memory usage by replacing the queue's underlying container with a list. #1083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0a506bc
Optimize memory usage by replacing the queue's underlying container w…
mssonicbld Sep 26, 2025
9a68c31
Update code
mssonicbld Sep 26, 2025
07df0b5
Merge branch 'master' into dev/liuh/improve_memury_util
liuh-80 Sep 26, 2025
03df595
Merge branch 'master' into dev/liuh/improve_memury_util
liuh-80 Sep 30, 2025
6de6232
Merge branch 'master' into dev/liuh/improve_memury_util
liuh-80 Oct 9, 2025
49988d1
Simplify queue declaration in notificationconsumer.h
liuh-80 Oct 11, 2025
e977afe
Remove list dependency from RedisPipeline
liuh-80 Oct 11, 2025
e0e249a
Merge branch 'master' into dev/liuh/improve_memury_util
liuh-80 Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion common/asyncdbupdater.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

#include <string>
#include <deque>
#include <list>
#include <condition_variable>
#include "dbconnector.h"
#include "table.h"
Expand Down Expand Up @@ -32,7 +33,7 @@ class AsyncDBUpdater

std::condition_variable m_dbUpdateDataNotifyCv;

std::queue<std::shared_ptr<KeyOpFieldsValuesTuple>> m_dbUpdateDataQueue;
std::queue<std::shared_ptr<KeyOpFieldsValuesTuple>, std::list<std::shared_ptr<KeyOpFieldsValuesTuple>>> m_dbUpdateDataQueue;

DBConnector *m_db;

Expand Down
3 changes: 2 additions & 1 deletion common/zmqconsumerstatetable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

#include <string>
#include <deque>
#include <list>
#include <condition_variable>
#include "asyncdbupdater.h"
#include "consumertablebase.h"
Expand Down Expand Up @@ -74,7 +75,7 @@ class ZmqConsumerStateTable : public Selectable, public TableBase, public ZmqMes

std::mutex m_receivedQueueMutex;

std::queue<std::shared_ptr<KeyOpFieldsValuesTuple>> m_receivedOperationQueue;
std::queue<std::shared_ptr<KeyOpFieldsValuesTuple>, std::list<std::shared_ptr<KeyOpFieldsValuesTuple>>> m_receivedOperationQueue;

swss::SelectableEvent m_selectableEvent;

Expand Down
Loading