Optimize memory usage by replacing the queue's underlying container with a list. #1083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @liuh-80 while it might help in some cases, it may not be universally true that using list as the underlying container optimizes memory. It would be good to have some more tests to make sure the following:
|
qiluo-msft
reviewed
Oct 11, 2025
Removed unnecessary list template from queue declaration.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize memory usage by replacing the queue's underlying container with a list.
Why I did it
std::queue using std::deque as default underlying container.
std::deque will not release container memory immediately after object pops from container.
How I did it
Replacing the queue's underlying container with a list. which will release memory immediately after object pops from container.
Work item tracking
How to verify it
Pass all test cases.
Manually verified this change will release memory.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Optimize memory usage by replacing the queue's underlying container with a list.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)