-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Replace puts
in tasks and generators with Rails.logger or Logger.new
#6244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6244 +/- ##
==========================================
- Coverage 88.82% 88.82% -0.01%
==========================================
Files 850 850
Lines 18334 18336 +2
==========================================
+ Hits 16286 16287 +1
- Misses 2048 2049 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@mamhoff there is a valid spec error https://github.com/solidusio/solidus/actions/runs/15340861947/job/43166600606?pr=6244 |
Head branch was pushed to by a user without write access
We should not use `puts` here, but instead the configured Rails logger. A log level of `info` is appropriate for all of these instances. In Generators, we use Thor's `say` method instead.
Summary
We should not use
puts
here, but instead the configured Rails logger. A log level ofinfo
is appropriate for all of these instances.In the Dummy App generator, Rails is not yet loaded, so we use the normal logger instead.
Extracted from #6240
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: