Skip to content

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 31, 2025

Summary

Due to a change in #6244 we now log to stdout in tests, instead of to the test.log file. This clutters test output on CircleCI

https://app.circleci.com/pipelines/github/solidusio/solidus/8111/workflows/1ccfe0fe-1905-4145-9d50-8af1c93f258b/jobs/80080/parallel-runs/0/steps/0-112

Instead we just let Rails / RSpec do their default logging.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

tvdeyen added 2 commits May 31, 2025 08:59
We want to write into the `test.log` instead, which rspec/rails
already set up for us.
@tvdeyen tvdeyen requested a review from a team as a code owner May 31, 2025 07:02
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label May 31, 2025
Copy link

codecov bot commented May 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.82%. Comparing base (cfb5acb) to head (abcf431).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6268      +/-   ##
==========================================
- Coverage   88.82%   88.82%   -0.01%     
==========================================
  Files         851      851              
  Lines       18349    18348       -1     
==========================================
- Hits        16299    16298       -1     
  Misses       2050     2050              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mamhoff
Copy link
Contributor

mamhoff commented May 31, 2025

Thanks for this find!

@tvdeyen tvdeyen merged commit f60d39d into solidusio:main Jun 2, 2025
25 checks passed
@tvdeyen tvdeyen deleted the remove-rails-logger-dummy-app branch June 2, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants