Skip to content

Hot reload fixes #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+25 −2
Open

Hot reload fixes #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afc1e37
Expose hot reload on device
tunabrain Jul 28, 2025
ed241fd
Check if hot reload is needed before executing jupyter cells
tunabrain Jul 28, 2025
7c5e4c4
Reload lookup modules on hot reload
tunabrain Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions slangpy/core/jupyter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,3 +265,9 @@ def setup_in_jupyter(device: Device):
pretty_formatter.for_type(Tensor, format_tensor)
pretty_formatter.for_type(NativeTensor, format_tensor)
pretty_formatter.for_type(Texture, format_texture)

if device.desc.enable_hot_reload:
# Set delay to 0 to avoid evaluating cells with stale kernels
device.set_hot_reload_delay(0)
# Trigger a hot-reload check before a cell gets executed to make sure we have the latest changes
ipython.events.register("pre_execute", lambda: device.hot_reload_check())
9 changes: 7 additions & 2 deletions slangpy/types/buffer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,16 @@ def _on_device_close(device: Device):
del global_lookup_modules[device]


def _load_lookup_module(device: Device):
dummy_module = device.load_module_from_source("slangpy_layout", 'import "slangpy";')
global_lookup_modules[device] = SlangProgramLayout(dummy_module.layout)


def get_lookup_module(device: Device) -> SlangProgramLayout:
if device not in global_lookup_modules:
dummy_module = device.load_module_from_source("slangpy_layout", 'import "slangpy";')
global_lookup_modules[device] = SlangProgramLayout(dummy_module.layout)
_load_lookup_module(device)
device.register_device_close_callback(_on_device_close)
device.register_shader_hot_reload_callback(lambda _: _load_lookup_module(device))

return global_lookup_modules[device]

Expand Down
12 changes: 12 additions & 0 deletions src/slangpy_ext/device/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#include "sgl/device/surface.h"
#include "sgl/device/shader.h"
#include "sgl/device/command.h"
#include "sgl/device/hot_reload.h"

#include "sgl/core/window.h"

Expand Down Expand Up @@ -872,6 +873,17 @@ SGL_PY_EXPORT(device_device)
[](Device* self, size_t offset) { return self->get_or_create_coop_vec()->align_vector_offset(offset); },
"offset"_a
);
device.def(
"set_hot_reload_delay",
[](Device* self, uint32_t delay_ms) { self->_hot_reload()->set_auto_detect_delay(delay_ms); },
"timeout_ms"_a,
D_NA(Device, set_hot_reload_delay)
);
device.def(
"hot_reload_check",
[](Device* self) { self->_hot_reload()->update(); },
D_NA(Device, hot_reload_check)
);

device.def_static(
"enumerate_adapters",
Expand Down