Hot reload fixes #382
Open
Hot reload fixes #382
+25
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccummingsNV
requested changes
Jul 29, 2025
src/slangpy_ext/device/device.cpp
Outdated
| D_NA(Device, set_hot_reload_delay) | ||
| ); | ||
| device.def( | ||
| "hot_reload", |
There was a problem hiding this comment.
This check should be called be something like "hot_reload_update" or "hot_reload_check". i.e. it shouldn't imply a hot reload will occur when you call it, because it might do nothing.
There was a problem hiding this comment.
Sounds good! PR adjusted to include this change.
tunabrain
force-pushed
the
dev/bbitterli/hot-reload-fixes
branch
from
4c8b5fe to
7c5e4c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of issues with hot reload:
Lookup modules are not reloaded after a hot reload, and trying to create an
NDBufferorTensorafter a hot reload has taken place will fail. The fix is to add a hot reload hook for lookup modules.Changing a loaded module, then e.g. evaluating a cell in Jupyter will still run the old shader code. The hot reload trigger runs on dispatch, and the shader is reloaded only after the next dispatch. This can be confusing when things don't run in a loop, e.g. in an interactive environment, as you need to run a cell twice to see the reloaded code. The fix is to re-add a jupyer hook that triggers a hot reload check before jupyter cells are evaluated.
This exposes hot reload functionality on the device. Input on how to expose this differently is welcome!