Skip to content

Conversation

@mjambon
Copy link
Member

@mjambon mjambon commented Oct 11, 2025

This is the main and last PR implementing support for capturing and checking output files produced by tests.

This introduces a new way for a test to terminate cleanly, Missing_output_file​, indicating that the test failed to call Testo.stash_output_file​ as expected from the test's specification. When this happens, we print a hint regarding what to do.

PR checklist:

  • Purpose of the code is evident to future readers
  • Tests are included or a PR comment includes a reproducible test plan
  • Documentation is up-to-date
  • A changelog entry was added to CHANGES.md for any user-facing change

Check out CONTRIBUTING.md for more details.

Copy link
Member Author

mjambon commented Oct 11, 2025

@mjambon mjambon mentioned this pull request Oct 11, 2025
4 tasks
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from 9d07a77 to 5994850 Compare October 12, 2025 08:44
@mjambon mjambon force-pushed the 10-05-implement_and_expose_stash_output_file_s_ branch from 049c5fb to e2d4e82 Compare October 13, 2025 02:33
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch 3 times, most recently from 7061bb5 to 4932fab Compare October 13, 2025 08:03
@mjambon mjambon force-pushed the 10-05-implement_and_expose_stash_output_file_s_ branch from e2d4e82 to ae8a6f4 Compare October 13, 2025 21:42
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch 2 times, most recently from 99cd627 to e782abd Compare October 13, 2025 21:48
@mjambon mjambon force-pushed the 10-05-implement_and_expose_stash_output_file_s_ branch from ae8a6f4 to a7d08f2 Compare October 13, 2025 21:48
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from e782abd to c2adc2d Compare October 13, 2025 22:07
@mjambon mjambon force-pushed the 10-05-implement_and_expose_stash_output_file_s_ branch 2 times, most recently from 201422b to c27dfa6 Compare October 13, 2025 22:36
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch 4 times, most recently from 500aaf4 to 668500e Compare October 13, 2025 23:37
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from 668500e to 29dd912 Compare October 13, 2025 23:41
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch 4 times, most recently from 2e4695b to 8f9ffa0 Compare October 14, 2025 00:12
@mjambon mjambon marked this pull request as ready for review October 14, 2025 00:49
@mjambon mjambon requested a review from ajbt200128 October 14, 2025 00:53
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from 8f9ffa0 to 76e172b Compare October 16, 2025 00:26
@mjambon mjambon force-pushed the 10-05-implement_and_expose_stash_output_file_s_ branch from c27dfa6 to 6b45c67 Compare October 16, 2025 00:26
Copy link
Member Author

mjambon commented Oct 16, 2025

Merge activity

  • Oct 16, 1:32 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 16, 1:49 AM UTC: Graphite rebased this pull request as part of a merge.
  • Oct 16, 1:54 AM UTC: @mjambon merged this pull request with Graphite.

@mjambon mjambon changed the base branch from 10-05-implement_and_expose_stash_output_file_s_ to graphite-base/141 October 16, 2025 01:44
@mjambon mjambon changed the base branch from graphite-base/141 to main October 16, 2025 01:48
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from 76e172b to b1a9190 Compare October 16, 2025 01:49
@mjambon mjambon merged commit 63543da into main Oct 16, 2025
7 checks passed
@mjambon mjambon deleted the 10-11-check_the_presence_and_contents_of_captured_output_files branch October 16, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants