Skip to content

Conversation

mjambon
Copy link
Member

@mjambon mjambon commented Oct 6, 2025

Closes #134

PR checklist:

  • Purpose of the code is evident to future readers
  • Tests are included or a PR comment includes a reproducible test plan
  • Documentation is up-to-date
  • A changelog entry was added to CHANGES.md for any user-facing change

Check out CONTRIBUTING.md for more details.

Copy link
Member Author

mjambon commented Oct 6, 2025

@mjambon mjambon force-pushed the 10-05-implement_and_expose_stash_output_file_s_ branch from 27f4501 to 049c5fb Compare October 8, 2025 04:43
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch from a159c07 to 575ee36 Compare October 8, 2025 04:43
@mjambon mjambon changed the base branch from 10-05-implement_and_expose_stash_output_file_s_ to graphite-base/139 October 11, 2025 09:15
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch from 575ee36 to c57086f Compare October 11, 2025 09:15
@mjambon mjambon changed the base branch from graphite-base/139 to 10-11-check_the_presence_and_contents_of_captured_output_files October 11, 2025 09:15
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch 2 times, most recently from 9b156c2 to 6ab635e Compare October 12, 2025 08:44
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from 9d07a77 to 5994850 Compare October 12, 2025 08:44
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch from 6ab635e to ef966e6 Compare October 13, 2025 02:33
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from 5994850 to e23bf88 Compare October 13, 2025 02:33
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch from ef966e6 to 3097b7f Compare October 13, 2025 07:44
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from e23bf88 to 7061bb5 Compare October 13, 2025 07:44
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch 2 times, most recently from 5bf1a77 to b0deee4 Compare October 13, 2025 08:03
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from 7061bb5 to 4932fab Compare October 13, 2025 08:03
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch 2 times, most recently from 360147a to a5501a4 Compare October 13, 2025 21:42
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from 6eb5cb8 to 99cd627 Compare October 13, 2025 21:42
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch from a5501a4 to 158e1b0 Compare October 13, 2025 21:48
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from 99cd627 to e782abd Compare October 13, 2025 21:48
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch from 158e1b0 to ac33b30 Compare October 13, 2025 22:07
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch 2 times, most recently from c2adc2d to efa9cc0 Compare October 13, 2025 22:36
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch from ac33b30 to 9d35a01 Compare October 13, 2025 22:36
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from efa9cc0 to 35c5c2d Compare October 13, 2025 23:00
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch from 9d35a01 to c4c70e7 Compare October 13, 2025 23:00
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from 35c5c2d to 500aaf4 Compare October 13, 2025 23:02
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch 2 times, most recently from 051cbff to 301ca6b Compare October 13, 2025 23:37
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from 500aaf4 to 668500e Compare October 13, 2025 23:37
@semgrep-zcs-prod-semgrep
Copy link

Semgrep found 1 bad-reraise finding:

You should not re-raise exceptions using 'raise' because it loses track of where the exception was raised originally, leading to a useless and possibly confusing stack trace. Instead, you should obtain a stack backtrace as soon as the exception is caught using 'try ... with exn -> let trace = Printexc.get_raw_backtrace () in ...', and keep it around until you re-raise the exception using 'Printexc.raise_with_backtrace exn trace'. You must collect the stack backtrace before calling another function which might internally raise and catch exceptions. To avoid false positives from Semgrep, write 'raise (Foo args)' instead of 'let e = Foo args in raise e'.

@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch from 301ca6b to 9efd1ca Compare October 13, 2025 23:41
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from 668500e to 29dd912 Compare October 13, 2025 23:41
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch from 9efd1ca to 64b2389 Compare October 13, 2025 23:46
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch 2 times, most recently from d83f9bf to cf1facb Compare October 14, 2025 00:03
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch 2 times, most recently from 1dde34c to a9eee9d Compare October 14, 2025 00:10
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from cf1facb to 2e4695b Compare October 14, 2025 00:10
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch from a9eee9d to 1682ac3 Compare October 14, 2025 00:12
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from 2e4695b to 8f9ffa0 Compare October 14, 2025 00:12
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch from 1682ac3 to 28d66f8 Compare October 14, 2025 00:29
@mjambon mjambon marked this pull request as ready for review October 14, 2025 00:50
@mjambon mjambon requested a review from ajbt200128 October 14, 2025 00:53
@mjambon mjambon force-pushed the 10-11-check_the_presence_and_contents_of_captured_output_files branch from 8f9ffa0 to 76e172b Compare October 16, 2025 00:26
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch from 28d66f8 to 7221107 Compare October 16, 2025 00:26
Copy link
Member Author

mjambon commented Oct 16, 2025

Merge activity

  • Oct 16, 1:32 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 16, 1:55 AM UTC: Graphite rebased this pull request as part of a merge.
  • Oct 16, 1:59 AM UTC: @mjambon merged this pull request with Graphite.

@mjambon mjambon changed the base branch from 10-11-check_the_presence_and_contents_of_captured_output_files to graphite-base/139 October 16, 2025 01:49
@mjambon mjambon changed the base branch from graphite-base/139 to main October 16, 2025 01:54
@mjambon mjambon force-pushed the 10-06-regenerate_html_docs branch from 7221107 to 76d2455 Compare October 16, 2025 01:55
@mjambon mjambon merged commit 56d79cf into main Oct 16, 2025
7 checks passed
@mjambon mjambon deleted the 10-06-regenerate_html_docs branch October 16, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an option to save an output file as a snapshot

2 participants