-
Notifications
You must be signed in to change notification settings - Fork 270
[Stackadapt Audiences] - API / Schema upgrade #2899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2899 +/- ##
=======================================
Coverage 77.86% 77.86%
=======================================
Files 1049 1049
Lines 19450 19450
Branches 3814 3814
=======================================
Hits 15145 15145
Misses 2965 2965
Partials 1340 1340 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @joe-ayoub-segment
I did unit testing by running the test locally. I think we can use the Event Tester
to try it out but I lost the link to the dev instance.
Thanks @Vanessa-SSY - any chance you could do a quick test and attach a screenshot? If something were to go wrong after we deploy it can take some time to roll back (and it would be a lot of effort). It's worth de-risking with an end to end local test first. After that this PR is ready to deploy |
LOCAL TESTING RESULT: |
This PR was originally raised by Stackadapt here. #2874
I copied the PR and fixed a couple of things from that PR:
Original PR summary below:
_A summary of your pull request, including the what change you're making and why.
When calling upsertProfileMapping mutation, there's an argument mapping_schema which takes a JSON blob. We are migrating it to mapping_schema_v2. It has defined GQL types for better validation and security.
It won't cause any issue if you keep using mapping_schema, but we want to deprecate mapping_schema at some point.
update field mapping to include label_
Testing
Hi @Vanessa-SSY - can you please comment provide the folowing?