Skip to content

[Stackadapt Audiences] - API / Schema upgrade #2899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joe-ayoub-segment
Copy link
Contributor

@joe-ayoub-segment joe-ayoub-segment commented May 6, 2025

This PR was originally raised by Stackadapt here. #2874

I copied the PR and fixed a couple of things from that PR:

  • I fixed the breaking Snapshot tests.
  • I removed the changes to the yarn.lock and package.json files

Original PR summary below:
_A summary of your pull request, including the what change you're making and why.

When calling upsertProfileMapping mutation, there's an argument mapping_schema which takes a JSON blob. We are migrating it to mapping_schema_v2. It has defined GQL types for better validation and security.
It won't cause any issue if you keep using mapping_schema, but we want to deprecate mapping_schema at some point.
update field mapping to include label_

Testing

Hi @Vanessa-SSY - can you please comment provide the folowing?

  1. provide some evidence of testing the new code.
  2. Indicate that you are happy for the new code to be deployed.

Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.86%. Comparing base (05317de) to head (3ff7308).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...s/stackadapt-audiences/forwardProfile/functions.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2899   +/-   ##
=======================================
  Coverage   77.86%   77.86%           
=======================================
  Files        1049     1049           
  Lines       19450    19450           
  Branches     3814     3814           
=======================================
  Hits        15145    15145           
  Misses       2965     2965           
  Partials     1340     1340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Vanessa-SSY Vanessa-SSY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @joe-ayoub-segment
I did unit testing by running the test locally. I think we can use the Event Tester to try it out but I lost the link to the dev instance.

@joe-ayoub-segment
Copy link
Contributor Author

Thanks @Vanessa-SSY - any chance you could do a quick test and attach a screenshot? If something were to go wrong after we deploy it can take some time to roll back (and it would be a lot of effort). It's worth de-risking with an end to end local test first.

After that this PR is ready to deploy

@Vanessa-SSY
Copy link
Contributor

Vanessa-SSY commented May 12, 2025

LOCAL TESTING RESULT:
Screenshot 2025-05-12 at 1 28 39 PM
CC @joe-ayoub-segment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants