Skip to content

StackAdapt audience destination: Migrate destination to use mappingSchemaV2 #2874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vanessa-SSY
Copy link
Contributor

@Vanessa-SSY Vanessa-SSY commented Apr 17, 2025

A summary of your pull request, including the what change you're making and why.

  • When calling upsertProfileMapping mutation, there's an argument mapping_schema which takes a JSON blob. We are migrating it to mapping_schema_v2. It has defined GQL types for better validation and security.
    It won't cause any issue if you keep using mapping_schema, but we want to deprecate mapping_schema at some point.
  • update field mapping to include label

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@Vanessa-SSY Vanessa-SSY requested a review from a team as a code owner April 17, 2025 20:23
@Vanessa-SSY Vanessa-SSY changed the title Migrate stackadapt segment engage destination to use mappingSchemaV2 StackAdapt audience destination: Migrate destination to use mappingSchemaV2 Apr 17, 2025
@Vanessa-SSY Vanessa-SSY force-pushed the vs/use-mappingSchemaV2 branch from 008eca2 to da9bc02 Compare April 21, 2025 20:28
@Vanessa-SSY Vanessa-SSY force-pushed the vs/use-mappingSchemaV2 branch from da9bc02 to 44bcd9c Compare April 21, 2025 20:32
Copy link
Contributor

@joe-ayoub-segment joe-ayoub-segment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Vanessa-SSY , thanks for the PR.

Please see the inline comment regarding the change to the package.json file.

I also noticed that the snapshot tests need to be updated as they are failing. Try this command:

yarn cloud test packages/destination-actions/src/destinations/stackadapt --updateSnapshot

Finally, do you have any proof of actual testing that this works with the new API? Would you be able to demonstrate that an end-to-end is able to send data through the two updated Actions? Some screenshots should be sufficient.

Cheers!
Joe

Comment on lines +117 to +119
"chance": "^1.1.8"
},
"packageManager": "[email protected]+sha512.ff4579ab459bb25aa7c0ff75b62acebe576f6084b36aa842971cf250a5d8c6cd3bc9420b22ce63c7f93a0857bc6ef29291db39c3e7a23aab5adfd5a4dd6c5d71"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Vanessa-SSY - I'm guessing you edited this file in error. Can you undo the change for this file please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants