-
Notifications
You must be signed in to change notification settings - Fork 65
Task/standardize command bar directions #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Task/standardize command bar directions #355
Conversation
Thank you for the pull request! ❤️The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
Thanks for this, @janiceferns02! We'll try to get to the review in the coming days :) |
All's looking good here, @janiceferns02! Really appreciate your initiative here 😊 Two minor comments based on the image below:
Please let us know if you have any questions on the comments above! |
…ections' into task/standardize-command-bar-directions
Understood, I will make the changes. |
Thanks much, @janiceferns02! Let us know when it's ready for another review 😊 |
Quick check in here, @janiceferns02 👋 Do you need any support with the changes for this PR :) We're happy to help as needed! 😊 |
Contributor checklist
./gradlew lintKotlin detekt test
command as directed in the testing section of the contributing guideDescription
Added : after the SOURCE_ISO -> TARGET_ISO part of the translate placeholder
To Fix the horizontal distance between the command bar cursor character and the rest of the text
Testing
Related issue