-
Notifications
You must be signed in to change notification settings - Fork 65
Implement Translate Mode Keyboard Switch #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Translate Mode Keyboard Switch #359
Conversation
Thank you for the pull request! ❤️The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
Sorry for the double commit... GitHub was super slow on the update of the branch and I thought it just didn't go through... |
And I didn't fix the error anyway. Could I ask you to clean up my commit and then address one thing, @angrezichatterbox? :) All is looking really really good here, but then there is one element of the keyboard UI that isn't being updated based on these changed. Specifically the prompt for the command bar for the translate command isn't being updated with a new ISO-2 code when the translation source language has been updated. You can see this in the image below where French is the source language and we still have the prompt as Would you be able to fix that and then we can merge this in? Sorry for the bit of mess on the commits/errors! |
Ah never mind, the above's coming through in #355 :) I'll merge that and then update this branch and then we'll be good to go once tests are passing! 😊 |
I will fix the detekt error :) Happy to help 😄 |
I should squash the duplicate commits right |
Ignore detekt/kdoc error
51d5ebe
to
a0af93c
Compare
8e21c37
to
555e5a4
Compare
Perfect, @angrezichatterbox! I'm realizing that the other PR actually doesn't do the change for the source language in the translate prompt. Would you be able to do that here and then I'll merge? :) I'll be leaving comments on the other one. |
Okay I will do that now. |
I have made the changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work here, @angrezichatterbox! And thanks so much for the quick response. I'm getting back from a bit of a break and it's such a help to be able to close things out so quickly post a review 😊 Let's be in touch on what comes next! 🚀
Contributor checklist
./gradlew lintKotlin detekt test
command as directed in the testing section of the contributing guideDescription
The PR introduces the feature to switch the keyboard to the keyboard language selected to be translated from for each language keyboard. The keyboard switches to the selected language from the settings when present in translate mode.
Related issue
Closes #265