Skip to content

Implement Translate Mode Keyboard Switch #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 11, 2025

Conversation

angrezichatterbox
Copy link
Member

Contributor checklist


Description

The PR introduces the feature to switch the keyboard to the keyboard language selected to be translated from for each language keyboard. The keyboard switches to the selected language from the settings when present in translate mode.

Related issue

Closes #265

Copy link

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Copy link

github-actions bot commented Apr 11, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Sorry for the double commit... GitHub was super slow on the update of the branch and I thought it just didn't go through...

@andrewtavis
Copy link
Member

And I didn't fix the error anyway. Could I ask you to clean up my commit and then address one thing, @angrezichatterbox? :) All is looking really really good here, but then there is one element of the keyboard UI that isn't being updated based on these changed. Specifically the prompt for the command bar for the translate command isn't being updated with a new ISO-2 code when the translation source language has been updated. You can see this in the image below where French is the source language and we still have the prompt as en -> de:

Screenshot_20250411_165204

Would you be able to fix that and then we can merge this in? Sorry for the bit of mess on the commits/errors!

@andrewtavis
Copy link
Member

Ah never mind, the above's coming through in #355 :) I'll merge that and then update this branch and then we'll be good to go once tests are passing! 😊

@angrezichatterbox
Copy link
Member Author

I will fix the detekt error :) Happy to help 😄

@angrezichatterbox
Copy link
Member Author

angrezichatterbox commented Apr 11, 2025

I should squash the duplicate commits right

Ignore detekt/kdoc error
@andrewtavis
Copy link
Member

Perfect, @angrezichatterbox! I'm realizing that the other PR actually doesn't do the change for the source language in the translate prompt. Would you be able to do that here and then I'll merge? :) I'll be leaving comments on the other one.

@angrezichatterbox
Copy link
Member Author

Perfect, @angrezichatterbox! I'm realizing that the other PR actually doesn't do the change for the source language in the translate prompt. Would you be able to do that here and then I'll merge? :) I'll be leaving comments on the other one.

Okay I will do that now.

@angrezichatterbox
Copy link
Member Author

I have made the changes :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work here, @angrezichatterbox! And thanks so much for the quick response. I'm getting back from a bit of a break and it's such a help to be able to close things out so quickly post a review 😊 Let's be in touch on what comes next! 🚀

@andrewtavis andrewtavis merged commit 486754e into scribe-org:main Apr 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Translation] Switch Keyboard to Translation source keyboard when Translate option is clicked
2 participants