Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions RELEASES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
Version 1.91.1 (2025-11-10)
===========================

<a id="1.91.1"></a>

- [Enable file locking support in illumos](https://github.com/rust-lang/rust/pull/148322). This fixes Cargo not locking the build directory on illumos.
- [Fix `wasm_import_module` attribute cross-crate](https://github.com/rust-lang/rust/pull/148363). This fixes linker errors on WASM targets.

Version 1.91.0 (2025-10-30)
==========================

Expand Down
2 changes: 1 addition & 1 deletion compiler/rustc_symbol_mangling/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ fn compute_symbol_name<'tcx>(
// However, we don't have the wasm import module map there yet.
tcx.is_foreign_item(def_id)
&& tcx.sess.target.is_like_wasm
&& tcx.wasm_import_module_map(LOCAL_CRATE).contains_key(&def_id.into())
&& tcx.wasm_import_module_map(def_id.krate).contains_key(&def_id.into())
};

if !wasm_import_module_exception_force_mangling {
Expand Down
6 changes: 6 additions & 0 deletions library/std/src/fs/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ use rand::RngCore;
target_os = "freebsd",
target_os = "linux",
target_os = "netbsd",
target_os = "illumos",
target_vendor = "apple",
))]
use crate::assert_matches::assert_matches;
Expand All @@ -14,6 +15,7 @@ use crate::char::MAX_LEN_UTF8;
target_os = "freebsd",
target_os = "linux",
target_os = "netbsd",
target_os = "illumos",
target_vendor = "apple",
))]
use crate::fs::TryLockError;
Expand Down Expand Up @@ -227,6 +229,7 @@ fn file_test_io_seek_and_write() {
target_os = "linux",
target_os = "netbsd",
target_os = "solaris",
target_os = "illumos",
target_vendor = "apple",
))]
fn file_lock_multiple_shared() {
Expand All @@ -251,6 +254,7 @@ fn file_lock_multiple_shared() {
target_os = "linux",
target_os = "netbsd",
target_os = "solaris",
target_os = "illumos",
target_vendor = "apple",
))]
fn file_lock_blocking() {
Expand All @@ -276,6 +280,7 @@ fn file_lock_blocking() {
target_os = "linux",
target_os = "netbsd",
target_os = "solaris",
target_os = "illumos",
target_vendor = "apple",
))]
fn file_lock_drop() {
Expand All @@ -298,6 +303,7 @@ fn file_lock_drop() {
target_os = "linux",
target_os = "netbsd",
target_os = "solaris",
target_os = "illumos",
target_vendor = "apple",
))]
fn file_lock_dup() {
Expand Down
10 changes: 10 additions & 0 deletions library/std/src/sys/fs/unix.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1286,6 +1286,7 @@ impl File {
target_os = "netbsd",
target_os = "openbsd",
target_os = "cygwin",
target_os = "illumos",
target_vendor = "apple",
))]
pub fn lock(&self) -> io::Result<()> {
Expand All @@ -1310,6 +1311,7 @@ impl File {
target_os = "openbsd",
target_os = "cygwin",
target_os = "solaris",
target_os = "illumos",
target_vendor = "apple",
)))]
pub fn lock(&self) -> io::Result<()> {
Expand All @@ -1323,6 +1325,7 @@ impl File {
target_os = "netbsd",
target_os = "openbsd",
target_os = "cygwin",
target_os = "illumos",
target_vendor = "apple",
))]
pub fn lock_shared(&self) -> io::Result<()> {
Expand All @@ -1347,6 +1350,7 @@ impl File {
target_os = "openbsd",
target_os = "cygwin",
target_os = "solaris",
target_os = "illumos",
target_vendor = "apple",
)))]
pub fn lock_shared(&self) -> io::Result<()> {
Expand All @@ -1360,6 +1364,7 @@ impl File {
target_os = "netbsd",
target_os = "openbsd",
target_os = "cygwin",
target_os = "illumos",
target_vendor = "apple",
))]
pub fn try_lock(&self) -> Result<(), TryLockError> {
Expand Down Expand Up @@ -1400,6 +1405,7 @@ impl File {
target_os = "openbsd",
target_os = "cygwin",
target_os = "solaris",
target_os = "illumos",
target_vendor = "apple",
)))]
pub fn try_lock(&self) -> Result<(), TryLockError> {
Expand All @@ -1416,6 +1422,7 @@ impl File {
target_os = "netbsd",
target_os = "openbsd",
target_os = "cygwin",
target_os = "illumos",
target_vendor = "apple",
))]
pub fn try_lock_shared(&self) -> Result<(), TryLockError> {
Expand Down Expand Up @@ -1456,6 +1463,7 @@ impl File {
target_os = "openbsd",
target_os = "cygwin",
target_os = "solaris",
target_os = "illumos",
target_vendor = "apple",
)))]
pub fn try_lock_shared(&self) -> Result<(), TryLockError> {
Expand All @@ -1472,6 +1480,7 @@ impl File {
target_os = "netbsd",
target_os = "openbsd",
target_os = "cygwin",
target_os = "illumos",
target_vendor = "apple",
))]
pub fn unlock(&self) -> io::Result<()> {
Expand All @@ -1496,6 +1505,7 @@ impl File {
target_os = "openbsd",
target_os = "cygwin",
target_os = "solaris",
target_os = "illumos",
target_vendor = "apple",
)))]
pub fn unlock(&self) -> io::Result<()> {
Expand Down
2 changes: 1 addition & 1 deletion src/version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.91.0
1.91.1
7 changes: 7 additions & 0 deletions tests/ui/wasm/auxiliary/link-name-in-foreign-crate.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#![no_std]

#[link(wasm_import_module = "test")]
unsafe extern "C" {
#[link_name = "close"]
pub fn close(x: u32) -> u32;
}
22 changes: 22 additions & 0 deletions tests/ui/wasm/wasm-link-name-in-foreign-crate-respected.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
//@ only-wasm32
//@ aux-build:link-name-in-foreign-crate.rs
//@ compile-flags: --crate-type cdylib
//@ build-pass
//@ no-prefer-dynamic

extern crate link_name_in_foreign_crate;

// This test that the definition of a function named `close`, which collides
// with the `close` function in libc in theory, is handled correctly in
// cross-crate situations. The `link_name_in_foreign_crate` dependency declares
// `close` from a non-`env` wasm import module and then this crate attempts to
// use the symbol. This should properly ensure that the wasm module name is
// tagged as `test` and the `close` symbol, to LLD, is mangled, to avoid
// colliding with the `close` symbol in libc itself.

#[unsafe(no_mangle)]
pub extern "C" fn foo() {
unsafe {
link_name_in_foreign_crate::close(1);
}
}
Loading