Skip to content

Conversation

@pietroalbini
Copy link
Member

This PR prepares the artifacts for Rust 1.91.1, targeting next Monday with the following backports:

cc @rust-lang/release

pietroalbini and others added 4 commits November 6, 2025 19:04
This commit fixes an accidental regression from 144678 where wasm
targets would now accidentally use the wrong import module map for a
symbol causing a symbol to skip mangling. This can result in compilation
failures when symbols are used in cross-crate situations.

Closes 148347
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Nov 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2025

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@pietroalbini
Copy link
Member Author

pietroalbini commented Nov 6, 2025

r? @Mark-Simulacrum (it doesn't have to be Mark, anyone from t-release would be great)

@BoxyUwU
Copy link
Member

BoxyUwU commented Nov 6, 2025

lgtm structurally, cant comment on the actual backported commits but I assume I don't need to care much about those since they already were reviewed 🤷‍♀️

r=me if you like

@BoxyUwU
Copy link
Member

BoxyUwU commented Nov 6, 2025

@bors p=20

i assume we probably want this to land soon after it's r+'d :>

@pietroalbini
Copy link
Member Author

@bors r=BoxyUwU p=100

@bors
Copy link
Collaborator

bors commented Nov 6, 2025

📌 Commit e42a4ca has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025
bors added a commit that referenced this pull request Nov 6, 2025
[stable] Prepare Rust 1.91.1

This PR prepares the artifacts for Rust 1.91.1, targeting next Monday with the following backports:

* #148322
* #148363

cc `@rust-lang/release`
@bors
Copy link
Collaborator

bors commented Nov 6, 2025

⌛ Testing commit e42a4ca with merge 04c99f2...

@Zalathar
Copy link
Member

Zalathar commented Nov 7, 2025

One of the runners (aarch64-apple) stalled and is very unlikely to finish before the timeout. 😿

It'll be faster to retry this PR now, before it hits the 6 hour mark.

@bors retry

@bors
Copy link
Collaborator

bors commented Nov 7, 2025

⌛ Testing commit e42a4ca with merge 6115e24...

bors added a commit that referenced this pull request Nov 7, 2025
[stable] Prepare Rust 1.91.1

This PR prepares the artifacts for Rust 1.91.1, targeting next Monday with the following backports:

* #148322
* #148363

cc `@rust-lang/release`
@bors
Copy link
Collaborator

bors commented Nov 7, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2025
@Zalathar
Copy link
Member

Zalathar commented Nov 7, 2025

This time a different runner flaked out.

@bors retry

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 7, 2025
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 7, 2025
@bors
Copy link
Collaborator

bors commented Nov 7, 2025

⌛ Testing commit e42a4ca with merge ed61e7d...

jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 7, 2025
…=pietroalbini

Backport 1.91.1 relnotes to main

Backport of the release notes from rust-lang#148593 to the main branch. This should land before Monday so that the automation creates the GitHub release.
@bors
Copy link
Collaborator

bors commented Nov 7, 2025

☀️ Test successful - checks-actions
Approved by: BoxyUwU
Pushing ed61e7d to stable...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 7, 2025
@bors bors merged commit ed61e7d into rust-lang:stable Nov 7, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.1 milestone Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants