-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[stable] Prepare Rust 1.91.1 #148593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable] Prepare Rust 1.91.1 #148593
Conversation
This commit fixes an accidental regression from 144678 where wasm targets would now accidentally use the wrong import module map for a symbol causing a symbol to skip mangling. This can result in compilation failures when symbols are used in cross-crate situations. Closes 148347
|
rustbot has assigned @JonathanBrouwer. Use |
|
r? @Mark-Simulacrum (it doesn't have to be Mark, anyone from t-release would be great) |
|
lgtm structurally, cant comment on the actual backported commits but I assume I don't need to care much about those since they already were reviewed 🤷♀️ r=me if you like |
|
@bors p=20 i assume we probably want this to land soon after it's r+'d :> |
|
@bors r=BoxyUwU p=100 |
[stable] Prepare Rust 1.91.1 This PR prepares the artifacts for Rust 1.91.1, targeting next Monday with the following backports: * #148322 * #148363 cc `@rust-lang/release`
|
One of the runners ( It'll be faster to retry this PR now, before it hits the 6 hour mark. @bors retry |
[stable] Prepare Rust 1.91.1 This PR prepares the artifacts for Rust 1.91.1, targeting next Monday with the following backports: * #148322 * #148363 cc `@rust-lang/release`
|
💔 Test failed - checks-actions |
|
This time a different runner flaked out. @bors retry |
…=pietroalbini Backport 1.91.1 relnotes to main Backport of the release notes from rust-lang#148593 to the main branch. This should land before Monday so that the automation creates the GitHub release.
|
☀️ Test successful - checks-actions |
This PR prepares the artifacts for Rust 1.91.1, targeting next Monday with the following backports:
wasm_import_moduleattribute cross-crate #148363cc @rust-lang/release