Split config_print_platform into finer grained options #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadime15
reviewed
Oct 30, 2025
Collaborator
nadime15
left a comment
nadime15
left a comment
There was a problem hiding this comment.
@KotorinMinami Thanks for working on that!
KotorinMinami
force-pushed
the
split_config_print_platform
branch
from
b7e3088 to
f4ab9c4
Compare
arichardson
approved these changes
Nov 7, 2025
nadime15
approved these changes
Nov 7, 2025
KotorinMinami
force-pushed
the
split_config_print_platform
branch
from
f4ab9c4 to
76aa373
Compare
Timmmm
changed the title
Timmmm
requested changes
Nov 11, 2025
KotorinMinami
force-pushed
the
split_config_print_platform
branch
from
76aa373 to
f19e248
Compare
pmundkur
requested changes
Nov 14, 2025
Collaborator
pmundkur
left a comment
pmundkur
left a comment
There was a problem hiding this comment.
Needs a typo fix, but otherwise LGTM.
KotorinMinami
force-pushed
the
split_config_print_platform
branch
from
f19e248 to
445dfd1
Compare
pmundkur
approved these changes
Nov 17, 2025
Timmmm
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the config_print_platform to five options:
The main problem with a single option was CLINT mtime: when a hart is halted in debug mode, it keeps printing the CLINT time, even though nothing is happening.
Fixes #1340