Skip to content

Conversation

@jn80842
Copy link

@jn80842 jn80842 commented Oct 14, 2025

currentlyEnabled should return false for any extensions that are not included in the current build.

@github-actions
Copy link

Test Results

2 101 tests  ±0   2 101 ✅ ±0   20m 45s ⏱️ +14s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit e88585e. ± Comparison against base commit 977fc2f.

Copy link
Collaborator

@pmundkur pmundkur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is driven by a pruned model. Wouldn't there be a similar case for hartSupports?

@Timmmm
Copy link
Collaborator

Timmmm commented Oct 15, 2025

Has anyone actually managed to compile a pruned model yet? I thought there were some issues with the termination measure or something? Maybe we should hold off on this until we know how it's going to work.

@jn80842
Copy link
Author

jn80842 commented Oct 15, 2025

If by a pruned model you mean a model compiled with only a subset of modules, then yes, we're working with one right now. Running cmake -S . -B build -DCMAKE_BUILD_TYPE=RelWithDebInfo -DSAIL_MODULES="postlude;Zicbom_insts;Zicboz;Zicsr_insts;Zkr" && cmake --build build --target generated_lean_executable_rv64d we get a model that compiles successfully (we're still debugging the executable, but I believe the bugs we're seeing now aren't related to the module system).

@Timmmm
Copy link
Collaborator

Timmmm commented Oct 15, 2025

Ah nice! We should probably add one or two examples to CI.

@jn80842 jn80842 marked this pull request as ready for review October 21, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants