Skip to content

Fix jalr circuit #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix jalr circuit #284

wants to merge 5 commits into from

Conversation

codygunton
Copy link
Contributor

@codygunton codygunton commented Sep 11, 2025 •
edited
Loading

Companion of risc0/risc0#3421
According to the spec for jalr

The target address is obtained by adding the sign-extended 12-bit I-immediate to the register rs1, then setting the least-significant bit of the result to zero.

This masking is done in the emulator but not in the circuit. This PR implements the masking at the circuit level as well.

@codygunton codygunton mentioned this pull request Sep 11, 2025
Open
jbruestle
jbruestle approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@jbruestle jbruestle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbruestle jbruestle jbruestle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codygunton @jbruestle