Consistently raise ValueError on corrupted cache data and test more #20153
+82
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test random and arbitrary cache data. Deserialization should fail in a predictable manner.
ilevkivskyi
approved these changes
Nov 1, 2025
| try: | ||
| check(data) | ||
| except BaseException as e: | ||
| print(">>>", e, data) |
There was a problem hiding this comment.
Maybe also print an instruction to open an issue whenever this happens. Otherwise people who are not familiar with this may simply rerun the test and it will pass, and we will never know about some rare edge case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test random and arbitrary cache data. Deserialization should fail in a predictable manner.