-
Notifications
You must be signed in to change notification settings - Fork 0
Document checklist for PR reviewers (and get feedback) #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Added section about automated PR reviewer checklists.
Hello @smoia! You're the first to be be assigned to this PR, which means that you've been nominated Main Reviewer! Lucky you! As a Main Reviewer, you are slightly more responsible for the quality of this PR than your fellow Reviewers. If you have any doubt, check this section on reviewing and this section on being the Main Reviewer of the documents. Before merging this PR, please check that:
If the PR contains code changes:
After you merged this PR, please check that:
Thank you! |
Hello @m-miedema! You've been assigned to this PR, which means that you've been nominated as reviewer! You are a supporting reviewer, not the main reviewer. The main reviewer has more responsibilities than you (lucky them) but your review is still important. For a guide, check out this section on reviewing. Please see the checklist that the main reviewer has been given (somewhere above this comment) and consider what support you can provide to them. Thank you! |
Hello @goodalse2019! You've been assigned to this PR, which means that you've been nominated as reviewer! You are a supporting reviewer, not the main reviewer. The main reviewer has more responsibilities than you (lucky them) but your review is still important. For a guide, check out this section on reviewing. Please see the checklist that the main reviewer has been given (somewhere above this comment) and consider what support you can provide to them. Thank you! |
Hello @CesarCaballeroGaudes! You've been assigned to this PR, which means that you've been nominated as reviewer! You are a supporting reviewer, not the main reviewer. The main reviewer has more responsibilities than you (lucky them) but your review is still important. For a guide, check out this section on reviewing. Please see the checklist that the main reviewer has been given (somewhere above this comment) and consider what support you can provide to them. Thank you! |
The purpose of this PR is to demonstrate the new workflow that automatically generates checklists for the main reviewer and supporting reviewers. These config files are already in the main branch, as this is a testing repo. If we like its functionality, we can implement it across other physiopy repos.
Please see the comments in this PR thread
Addresses physiopy/phys2bids#316
For now, I have tagged all the steering committee members for feedback, but other people are welcome to review this PR as well.
Feedback requested: