Skip to content

Add Main Reviewer checklist #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Add Main Reviewer checklist #316

wants to merge 5 commits into from

Conversation

smoia
Copy link
Member

@smoia smoia commented Oct 14, 2020

Closes none, depends on #315

This is a draft because I'm not totally sure the workflow is right.

Proposed Changes

  • Add a GH Action to create comment addressing the main reviewer when a PR gets assigned.
  • Add the template to provide the main reviewer with a checklist of things to do before (and after) merging.

@smoia smoia added Paused Issue should not be worked on until the resolution of other issues or Pull Requests Skip release This PR preserves the current version when merged, and doesn't appear in the changelog Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog labels Oct 14, 2020
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #316 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files           9        9           
  Lines         848      848           
=======================================
  Hits          804      804           
  Misses         44       44

@eurunuela
Copy link
Collaborator

Wow, I'm so excited for this! Let me know if there's anything I can do to help with this.

@RayStick
Copy link
Member

This is a good idea! I will take a look at what you have so far, on Monday, and see if I have suggestions at this stage.

@RayStick
Copy link
Member

This PR was marked as a work in progress a while ago. Should I look at it soon or wait?

@eurunuela
Copy link
Collaborator

#315 was already merged, I think we can continue work on this PR.

@smoia
Copy link
Member Author

smoia commented May 14, 2021

The main problem with this PR is that I didn't test it yet. If someone that has a bit of free time wants to try this out in a fake repository, please do so and help out finishing it!

@smoia smoia removed the Paused Issue should not be worked on until the resolution of other issues or Pull Requests label Apr 18, 2024
@smoia
Copy link
Member Author

smoia commented Apr 18, 2024

This PR might need updating, as well as more looking into how to make this work with our project board

@smoia smoia self-assigned this Apr 18, 2024
@RayStick RayStick self-assigned this Apr 19, 2024
@RayStick RayStick mentioned this pull request Apr 19, 2024
Closed
5 tasks
@RayStick RayStick mentioned this pull request Jan 9, 2025
Merged
18 tasks
@RayStick
Copy link
Member

@smoia - I think I fixed it :) see here: physiopy/physiopy-automations#25

@RayStick RayStick moved this from Need help! to In Progress in Physiopy Aug 26, 2025
@RayStick RayStick mentioned this pull request Sep 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smoia smoia

@RayStick RayStick

Labels
Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog Skip release This PR preserves the current version when merged, and doesn't appear in the changelog
Projects
Physiopy
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smoia @eurunuela @RayStick