-
Notifications
You must be signed in to change notification settings - Fork 5
32 update payment channel #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NhoxxKienn
wants to merge
9
commits into
master
Choose a base branch
from
32_update_payment_channel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2f0884a
feat: add additional pipeline for archived examples
NhoxxKienn cb8c9fc
fix: degrade the ganache version to fit the colalteralized channels
NhoxxKienn a9381d6
fix(collateralized channels): revert back to original version
NhoxxKienn 0028069
chore: update README and move the old examples to archived directory …
NhoxxKienn 7c926c9
Merge branch 'master' into 31_archive_old_example
NhoxxKienn 900ad46
chore(ci): fix dfx version and wait time
NhoxxKienn 6b404c5
feat(payment-channel): update to go-perun 0.13.0
NhoxxKienn c1be67d
feat: use libp2p wire instead of local bus
NhoxxKienn 42d0c79
chore(ci): reduce icp deployment waitime
NhoxxKienn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
name: Archived Examples CI | ||
on: | ||
workflow_dispatch: | ||
push: | ||
branches: | ||
- master | ||
pull_request: | ||
branches: | ||
- master | ||
|
||
jobs: | ||
test-examples: | ||
name: Test Examples | ||
runs-on: ubuntu-latest | ||
env: | ||
ganache-image: trufflesuite/ganache-cli:v6.12.2 | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-go@v5 | ||
with: | ||
go-version: '1.23' | ||
- run: go version | ||
|
||
- uses: actions/cache@v4 | ||
with: | ||
path: | | ||
~/.cache/go-build | ||
~/go/pkg/mod | ||
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }} | ||
restore-keys: | | ||
${{ runner.os }}-go- | ||
|
||
- name: Pull ganache-cli image | ||
run: docker pull ${{ env.ganache-image }} | ||
|
||
- name: Simple Client | ||
working-directory: archived/simple-client | ||
env: | ||
MNEMONIC: pistol kiwi shrug future ozone ostrich match remove crucial oblige cream critic | ||
run: | | ||
docker run --rm --name ganache --detach --publish 8545:8545 ${{ env.ganache-image }} -b 5 -a 2 -m "$MNEMONIC" | ||
sleep 5 | ||
go run . | ||
docker stop ganache | ||
|
||
- name: Collateralized Channels | ||
working-directory: archived/collateralized-channels | ||
env: | ||
GANACHE_CMD: "docker run --name ganache --rm --publish 8545:8545 ${{ env.ganache-image }}" | ||
run: | | ||
docker stop ganache || true # Cleanup any previous instance | ||
|
||
go test -v -timeout 60s . | ||
docker stop ganache || true | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule perun-eth-contracts
updated
37 files
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,13 @@ | ||||||
# Collateralized Channels (Archived ⚠️) | ||||||
|
||||||
## Dependencies | ||||||
This example requires the [ganache-cli](https://github.com/trufflesuite/ganache-cli) `v6.12.2` and [go-perun](https://github.com/hyperledger-labs/go-perun) `v0.6.0` . Newer versions of the dependencies might not be compatible. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The README still references go-perun v0.6.0, but the example now uses v0.13.0. Please update the version requirement accordingly.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
|
||||||
## Run the example | ||||||
|
||||||
Install [ganache-cli](https://github.com/trufflesuite/ganache-cli) `v6.12.2` and run | ||||||
``` | ||||||
go test -v perun.network/perun-collateralized-channels | ||||||
``` | ||||||
|
||||||
The test starts a ganache-cli in the background. If the test does not shut down in order, make sure to kill the corresponding `node` process manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Reducing the sleep from 30s to 5s may cause flaky CI runs if deployment takes longer. Consider a health check or a longer timeout.
Copilot uses AI. Check for mistakes.