32 update payment channel #41

NhoxxKienn · 2025-05-16T08:26:47Z

Description

This is part of multiple PRs to solve the issue #29, specifically solve the sub-issue #32. It updates the go-perun's dependency to v0.13.0

Location

/payment-channel/

Features

Update example to go-perun v0.13.0
Adjust README

Signed-off-by: Minh Huy Tran <[email protected]>

…+ remove simple client from active CI Signed-off-by: Minh Huy Tran <[email protected]>

Signed-off-by: Minh Huy Tran <[email protected]>

Copilot

Pull Request Overview

This PR updates the payment channel example to work with go-perun v0.13.0 and adjusts client and app code accordingly. Key changes include modifications in client receiver types and method names, updates of error handling and context usage in channel methods, and changes within CI workflows and documentation to support the new dependency version.

Reviewed Changes

Copilot reviewed 547 out of 547 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
archived/collateralized-channels/client/util.go	New utility functions for channel operations and state updates.
archived/collateralized-channels/client/handle.go	Renamed receivers and updated proposal/update handling logic.
archived/collateralized-channels/client/eth.go	Updated transactor retrieval and receipt confirmation.
archived/collateralized-channels/client/client.go	Introduced major client implementation with channel proposal and update logic.
archived/collateralized-channels/app/util.go and app/app.go	Adjusted app data casting and encoding to use value types instead of pointers.
archived/collateralized-channels/README.md	Updated documentation for clarity on dependency compatibility.
app-channel/contracts/perun-eth-contracts, README.md, and CI workflows	Updated submodule commit, added archived examples documentation, and refined CI configuration.

Comments suppressed due to low confidence (2)

archived/collateralized-channels/client/client.go:161

Returning an error message based on a nil 'err' when the channel is not found can lead to unclear error propagation. Replace it with a meaningful error creation (e.g. errors.New("channel not found")).

if !ok { return errors.WithMessage(err, "getting channel") }

archived/collateralized-channels/client/client.go:177

Similar to the previous case, returning an error using a nil 'err' when the channel is not found in the Settle method makes the error unclear. Create and return a new error message instead.

if !ok { return errors.WithMessage(err, "getting channel") }

Copilot · 2025-05-20T08:26:56Z

archived/collateralized-channels/client/client.go

+		if err != nil {
+			return errors.WithMessage(err, "creating peers")
+		}


An 'if err != nil' check is present immediately after initializing the peers slice, but no error is produced in the preceding code. Remove this check or replace it with the intended error handling logic.

Suggested change

if err != nil {

return errors.WithMessage(err, "creating peers")

}

Copilot

Pull Request Overview

Updates the collateralized channels example to use go-perun v0.13.0, adjusts client APIs, and refreshes documentation and CI accordingly

Bumps go-perun dependency and adapts API changes in client and app code
Updates archived example README and main README to reflect new organization
Adjusts GitHub Actions workflows (CI and archived CI) and submodule for perun-eth-contracts

Reviewed Changes

Copilot reviewed 547 out of 547 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
archived/collateralized-channels/client/util.go	Adapted to new perun API, adjusted error messages
archived/collateralized-channels/client/handle.go	Refactored handlers to use updated channel types and locking
archived/collateralized-channels/client/eth.go	Switched to perunClient transactor and backend fields
archived/collateralized-channels/client/client.go	Integrated new perunClient, fixed channel setup and funding logic
archived/collateralized-channels/app/util.go	Migrated app data to value type, updated balance helpers
archived/collateralized-channels/app/app.go	Implemented Encode/Clone for CollateralAppData
archived/collateralized-channels/README.md	Lists dependencies (needs version bump)
app-channel/contracts/perun-eth-contracts	Updated submodule commit
README.md	Added “Archived Examples” section
.github/workflows/ci.yml	Bumped DFX version, shortened sleep timings
.github/workflows/ci-archived.yml	Introduced workflow for archived examples

Comments suppressed due to low confidence (2)

archived/collateralized-channels/client/eth.go:27

Move the err check before setting tr.Context. If NewTransactor returns an error, tr will be nil and tr.Context = ctx will panic.

tr.Context = ctx

archived/collateralized-channels/app/util.go:89

wallet.Address does not have a Cmp method. Restore the original p.Equal(walletAddr) or use the correct comparison API.

if p.Cmp(walletAddr) == 0 {

Copilot · 2025-05-20T08:48:29Z

archived/collateralized-channels/client/client.go

+		if err != nil {
+			return errors.WithMessage(err, "creating peers")
+		}


This err is never set in this block (peers creation cannot error), so the check is dead code. Remove the if err != nil and its branch.

Suggested change

if err != nil {

return errors.WithMessage(err, "creating peers")

}

Copilot · 2025-05-20T08:48:29Z

archived/collateralized-channels/client/client.go

+
+	ch, ok := c.channels[peer]
+	if !ok {
+		return errors.WithMessage(err, "getting channel")


When ch is not found, err is nil, so WithMessage(nil,…) returns nil. Use errors.New("getting channel: not found") or attach a new error instead.

Suggested change

return errors.WithMessage(err, "getting channel")

return errors.New("getting channel: not found")

Copilot · 2025-05-20T08:48:29Z

archived/collateralized-channels/client/client.go

+
+	ch, ok := c.channels[peer]
+	if !ok {
+		return errors.WithMessage(err, "getting channel")


Same issue as above: err is nil when channel lookup fails. Replace with a fresh error like errors.New("channel not found").

Suggested change

return errors.WithMessage(err, "getting channel")

return errors.New("channel not found")

Copilot · 2025-05-20T08:48:30Z

archived/collateralized-channels/client/util.go

+		return nil, errors.New("channel not found")
+	}
+	b, err = c.assetHolder.Holdings(nil, calcChannelCollateralID(ch.ID(), c.Address()))
+	return b, errors.WithMessage(err, "reading peer collateral")


This error wraps a channel collateral lookup. Update the message to "reading channel collateral" to avoid confusion.

Suggested change

return b, errors.WithMessage(err, "reading peer collateral")

return b, errors.WithMessage(err, "reading channel collateral")

Copilot · 2025-05-20T08:48:30Z

archived/collateralized-channels/README.md

+# Collateralized Channels (Archived ⚠️)
+
+## Dependencies
+This example requires the [ganache-cli](https://github.com/trufflesuite/ganache-cli) `v6.12.2` and [go-perun](https://github.com/hyperledger-labs/go-perun) `v0.6.0` . Newer versions of the dependencies might not be compatible.


The README still references go-perun v0.6.0, but the example now uses v0.13.0. Please update the version requirement accordingly.

Suggested change

This example requires the [ganache-cli](https://github.com/trufflesuite/ganache-cli) `v6.12.2` and [go-perun](https://github.com/hyperledger-labs/go-perun) `v0.6.0` . Newer versions of the dependencies might not be compatible.

This example requires the [ganache-cli](https://github.com/trufflesuite/ganache-cli) `v6.12.2` and [go-perun](https://github.com/hyperledger-labs/go-perun) `v0.13.0` . Newer versions of the dependencies might not be compatible.

Copilot · 2025-05-20T08:48:30Z

.github/workflows/ci.yml

          ./startdeploy.sh

-          sleep 30
+          sleep 5


[nitpick] Reducing the sleep from 30s to 5s may cause flaky CI runs if deployment takes longer. Consider a health check or a longer timeout.

NhoxxKienn added 9 commits May 14, 2025 11:11

feat: add additional pipeline for archived examples

2f0884a

Signed-off-by: Minh Huy Tran <[email protected]>

fix: degrade the ganache version to fit the colalteralized channels

cb8c9fc

Signed-off-by: Minh Huy Tran <[email protected]>

fix(collateralized channels): revert back to original version

a9381d6

Signed-off-by: Minh Huy Tran <[email protected]>

chore: update README and move the old examples to archived directory …

0028069

…+ remove simple client from active CI Signed-off-by: Minh Huy Tran <[email protected]>

Merge branch 'master' into 31_archive_old_example

7c926c9

chore(ci): fix dfx version and wait time

900ad46

Signed-off-by: Minh Huy Tran <[email protected]>

feat(payment-channel): update to go-perun 0.13.0

6b404c5

Signed-off-by: Minh Huy Tran <[email protected]>

feat: use libp2p wire instead of local bus

c1be67d

Signed-off-by: Minh Huy Tran <[email protected]>

chore(ci): reduce icp deployment waitime

42d0c79

Signed-off-by: Minh Huy Tran <[email protected]>

NhoxxKienn requested a review from Copilot May 20, 2025 08:26

Copilot AI reviewed May 20, 2025

View reviewed changes

NhoxxKienn requested review from Copilot and iljabvh May 20, 2025 08:45

Copilot AI reviewed May 20, 2025

View reviewed changes

iljabvh approved these changes Sep 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

32 update payment channel #41

32 update payment channel #41

Uh oh!

NhoxxKienn commented May 16, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 20, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 20, 2025

Uh oh!

Copilot AI May 20, 2025

Uh oh!

Copilot AI May 20, 2025

Uh oh!

Copilot AI May 20, 2025

Uh oh!

Copilot AI May 20, 2025

Uh oh!

Copilot AI May 20, 2025

Uh oh!

Uh oh!

	if err != nil {
	return errors.WithMessage(err, "creating peers")
	}

	return errors.WithMessage(err, "getting channel")
	return errors.New("getting channel: not found")

	return errors.WithMessage(err, "getting channel")
	return errors.New("channel not found")

	return b, errors.WithMessage(err, "reading peer collateral")
	return b, errors.WithMessage(err, "reading channel collateral")

	This example requires the [ganache-cli](https://github.com/trufflesuite/ganache-cli) `v6.12.2` and [go-perun](https://github.com/hyperledger-labs/go-perun) `v0.6.0` . Newer versions of the dependencies might not be compatible.
	This example requires the [ganache-cli](https://github.com/trufflesuite/ganache-cli) `v6.12.2` and [go-perun](https://github.com/hyperledger-labs/go-perun) `v0.13.0` . Newer versions of the dependencies might not be compatible.

32 update payment channel #41

Are you sure you want to change the base?

32 update payment channel #41

Uh oh!

Conversation

NhoxxKienn commented May 16, 2025

Description

Location

Features

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!