AO3-6738 Resolve N+1 query in PseudsController#index

app/controllers/pseuds_controller.rb

@@ -17,6 +17,7 @@ def index
     @pseuds = @user.pseuds.with_attached_icon.alphabetical.paginate(page: params[:page])
     @rec_counts = Pseud.rec_counts_for_pseuds(@pseuds)
     @work_counts = Pseud.work_counts_for_pseuds(@pseuds)
+    @pseuds_with_works = Pseud.has_works_for(@pseuds.collect(&:id)) if @user == current_user
     @page_subtitle = @user.login
   end
 

app/models/pseud.rb

@@ -116,6 +116,13 @@ def to_param
       ).group('pseuds.id')
   }
 
+  scope :has_works_for, lambda { |pseud_ids|
+    joins(:works)
+      .where(pseuds: { id: pseud_ids })
+      .distinct
+      .pluck(:id)
+  }
+
   scope :public_rec_count_for, -> (pseud_ids) {
     select('pseuds.id, count(pseuds.id) AS rec_count')
     .joins(:bookmarks)

app/views/pseuds/_pseud_blurb.html.erb

@@ -17,7 +17,7 @@
                 edit_user_pseud_path(@user, pseud),
                 id: "edit_#{pseud.name.downcase.gsub(' ', '_')}"
               ) %></li>
-      <% if pseud.works.present? && current_user == pseud.user %>
+      <% if current_user == pseud.user && @pseuds_with_works.include?(pseud.id) %>
         <li><%= link_to(
                   t(".orphan_html",
                     landmark_span: content_tag(:span,

spec/requests/pseuds_n_plus_one_spec.rb

@@ -26,8 +26,7 @@
 
     warmup { subject.call }
 
-    # TODO: https://otwarchive.atlassian.net/browse/AO3-6738
-    xit "produces a constant number of queries" do
+    it "produces a constant number of queries" do
       expect { subject.call }
         .to perform_constant_number_of_queries
     end