AO3-6738 Resolve N+1 query in PseudsController#index #5428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilize displayed work counts instead of querying works. However, this *does* change functionality: a pseud with only unposted drafts will no longer see the orphan pseud button.
|
The bigger concern over drafts may be that it also doesn't count hidden works? |
Oops. Yeah, I'll just count it separately then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6738
Purpose
Resolves the N+1 query in
PseudsController#indexby reusing the work counts used for display.Notably, this means that a pseud with only draft works will no longer have an 'Orphan Pseud' button. I think this is acceptable since they wouldn't have a works listing in the blurb anyways, but I'm open to changing this if not.
Credit
marcus8448 (he/him)