Skip to content

Fix open parenthesis on user saved trips #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 20, 2025
Merged

Fix open parenthesis on user saved trips #1479

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d66745
Fix open parenthesis on user saved trips
amy-corson-ibigroup Oct 6, 2025
b0cca2b
create short name if location is custom
amy-corson-ibigroup Oct 15, 2025
eade251
Merge branch 'dev' into fix-user-saved-place-trips
amy-corson-ibigroup Oct 15, 2025
b314a39
including dining type
amy-corson-ibigroup Oct 15, 2025
5d8bc42
Merge branch 'dev' into fix-user-saved-place-trips
amy-corson-ibigroup Oct 20, 2025
0f8d70f
change shortname check to home and work
amy-corson-ibigroup Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/components/form/user-settings-i18n.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ function findLocationType(
? getFormattedPlaces(match.type, intl)
: null
}
function findCustomLocationShortName(location, locations = []) {
const match = locations.find((l) => matchLatLon(l, location))
return match && (match.type === 'custom' || match.type === 'dining')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Try excluding "Home" and "Work" instead?

? `${match.name} (${stripAllButNameOfAddress(match.address)})`
: null
}
export function summarizeQuery(query, intl, locations = []) {
if (!query.from.name) {
query.from.name = intl.formatMessage(
Expand All @@ -58,9 +64,11 @@ export function summarizeQuery(query, intl, locations = []) {
.join(',') || ''
const from =
findLocationType(intl, query.from, locations) ||
findCustomLocationShortName(query.from, locations) ||
stripAllButNameOfAddress(query.from.name)
const to =
findLocationType(intl, query.to, locations) ||
findCustomLocationShortName(query.to, locations) ||
stripAllButNameOfAddress(query.to.name)
const mode = hasTransit(modes)
? intl.formatMessage({ id: 'common.modes.transit' })
Expand Down
Loading