Fix open parenthesis on user saved trips #1479
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return string.split(',')[0] | ||
| let newString = string.split(',')[0] | ||
| // If there is an open parenthesis without a close (user saved place), add one. | ||
| if (newString.includes('(') && !newString.includes(')')) { |
There was a problem hiding this comment.
What about this string? Coffee (Starbucks (Market & 20th)? I think you may need to actually count the open and close parentheses 🙃 I knew this leetcode problem would come in handy one day!!
|
Revised the approach! Much easier than I expected it to be, although slightly different than what we discussed on our call. Reassigning @binh-dam-ibigroup to re-review |
binh-dam-ibigroup
approved these changes
Oct 20, 2025
| } | ||
| function findCustomLocationShortName(location, locations = []) { | ||
| const match = locations.find((l) => matchLatLon(l, location)) | ||
| return match && (match.type === 'custom' || match.type === 'dining') |
There was a problem hiding this comment.
Nit: Try excluding "Home" and "Work" instead?
alec-georgoff
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug where user saved trips, which are formatted
nickname (placename)were not showing the close parenthesis in the previous trips pane.Open to another approach or laying out the user places in a different way. Are there cases where there could be a "(" character in a name that does not require a close parenthesis?
PR Checklist: