Upgrade maplibre and react-map-gl #1452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 341a7ff.
Closed
3 tasks
amy-corson-ibigroup
approved these changes
Aug 18, 2025
| @@ -210,7 +211,8 @@ function NearbyView({ | |||
| }, [location, setHighlightedLocation]) | |||
|
|
|||
| useEffect(() => { | |||
| const moveListener = (e: mapboxgl.EventData) => { | |||
| const moveListener = (e: ViewStateChangeEvent) => { | |||
| // @ts-expect-error TODO: What is this condition supposed to capture? | |||
There was a problem hiding this comment.
Can you explain how the ts error could be solved by answering this question?
| // onMouseLeave is throttled because of a bug on Firefox where | ||
| // two mouseleave events are triggered when moving cursor quickly from one card to the next. | ||
| const onMouseLeave = useCallback( | ||
| throttle( |
There was a problem hiding this comment.
Any concerns with increasing bundle size for this? It looks like a very small package, just curious if you looked at any other solutions
josh-willis-arcadis
requested changes
Aug 20, 2025
josh-willis-arcadis
approved these changes
Aug 20, 2025
There was a problem hiding this comment.
Updating my review as the nearby view error will be fixed in #1457.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades maplibre and react-map-gl by way of new OTP-UI packages that use those updated libraries.
There shouldn't be any visual changes on non-map content.
PR Checklist