Skip to content

Conversation

amy-corson-ibigroup
Copy link
Contributor

Description:

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Let's let the location field marinate a bit longer

@binh-dam-ibigroup
Copy link
Collaborator

@amy-corson-ibigroup This PR is probably superseded by #1452.

@amy-corson-ibigroup
Copy link
Contributor Author

@binh-dam-ibigroup Is there a reason why #1452 would block these updates? Gotten the impression from @miles-grant-ibigroup that merging these otp-ui updates is a little time sensitive but I may be wrong

@miles-grant-ibigroup
Copy link
Collaborator

I'm ok waiting for #1452. It seems to encompass all of this

@binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup Is there a reason why #1452 would block these updates?

#1452 does not block this PR but contains it!

@amy-corson-ibigroup
Copy link
Contributor Author

Closing in favor of #1452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants