Skip to content

[release-4.18] OCPBUGS-54724: Fix implementation of ContainsCIDR to allow non-equal addresses #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from
Open

[release-4.18] OCPBUGS-54724: Fix implementation of ContainsCIDR to allow non-equal addresses #2267

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2263

/assign JoelSpeed

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 8, 2025
Merged
@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Apr 8, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-54426 has been cloned as Jira Issue OCPBUGS-54724. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-54724: Fix implementation of ContainsCIDR to allow non-equal addresses

In response to this:

This is an automated cherry-pick of #2263

/assign JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bertinatto and p0lyn0mial April 8, 2025 14:26
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Apr 8, 2025
@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-54426: Fix implementation of ContainsCIDR to allow non-equal addresses [release-4.18] OCPBUGS-54724: Fix implementation of ContainsCIDR to allow non-equal addresses Apr 8, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 8, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-54724, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-54426 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #2263

/assign JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 8, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

bertinatto
bertinatto reviewed Apr 8, 2025
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2025
ormergi added a commit to ormergi/cluster-network-operator that referenced this pull request Apr 23, 2025
@ormergi
bindata,ovn-k,cudn: Validate excludeSubnet match specified subnets
9e8ee1a 
Add CEL validation to ensure the specified excludeSubnetes match the
specified subnets.

This change make the CRD diverge from the CRD on U/S due to a bug [1]
that its fix is available on D/S [2] [3] but not available on U/S yet.

[1] https://issues.redhat.com/browse/OCPBUGS-54426
[2] openshift/kubernetes#2263
[3] openshift/kubernetes#2267

Signed-off-by: Or Mergi <[email protected]>
ormergi added a commit to ormergi/cluster-network-operator that referenced this pull request Apr 23, 2025
@ormergi
bindata,ovn-k,cudn: Validate excludeSubnet match specified subnets
197d806 
Add CEL validation on OVN-K CUDN CRD for localnet to topology, to ensure
the specified excludeSubnetes match the specified subnets.

This change make the CRD diverge from the CRD on U/S due to a bug [1]
that its fix is available on D/S [2] [3] but not available on U/S yet.

[1] https://issues.redhat.com/browse/OCPBUGS-54426
[2] openshift/kubernetes#2263
[3] openshift/kubernetes#2267

Signed-off-by: Or Mergi <[email protected]>
@ormergi ormergi mentioned this pull request Apr 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

Assignees

@bertinatto bertinatto

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @openshift-ci-robot @bertinatto @JoelSpeed