OCPBUGS-54426: Fix implementation of ContainsCIDR to allow non-equal addresses #2263
Conversation
openshift-ci-robot
added
backports/validated-commits
|
@JoelSpeed: This pull request references Jira Issue OCPBUGS-54426, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@JoelSpeed: the contents of this pull request could be automatically validated. The following commits are valid:
Comment |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@JoelSpeed: This pull request references Jira Issue OCPBUGS-54426, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test integration |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cherry-pick release-4.18 |
|
@JoelSpeed: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@JoelSpeed: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@JoelSpeed: An error was encountered searching for bug OCPBUGS-54426 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
No response returned: Get "https://issues.redhat.com/rest/api/2/issue/OCPBUGS-54426": GET https://issues.redhat.com/rest/api/2/issue/OCPBUGS-54426 giving up after 5 attempt(s)
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@JoelSpeed: new pull request created: #2267 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-pod |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-hyperkube |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-kube-apiserver-artifacts |
|
[ART PR BUILD NOTIFIER] Distgit: kube-proxy |
Add CEL validation to ensure the specified excludeSubnetes match the specified subnets. This change make the CRD diverge from the CRD on U/S due to a bug [1] that its fix is available on D/S [2] [3] but not available on U/S yet. [1] https://issues.redhat.com/browse/OCPBUGS-54426 [2] openshift/kubernetes#2263 [3] openshift/kubernetes#2267 Signed-off-by: Or Mergi <[email protected]>
Add CEL validation on OVN-K CUDN CRD for localnet to topology, to ensure the specified excludeSubnetes match the specified subnets. This change make the CRD diverge from the CRD on U/S due to a bug [1] that its fix is available on D/S [2] [3] but not available on U/S yet. [1] https://issues.redhat.com/browse/OCPBUGS-54426 [2] openshift/kubernetes#2263 [3] openshift/kubernetes#2267 Signed-off-by: Or Mergi <[email protected]>
This has already merged into the main and 1.33 branch of K/K, but we are waiting on cherry-pick approval for the 1.32 branch.
This updates the implementation of the CEL CIDR matching check which was rejecting some valid values.