Skip to content

OCPBUGS-65681: Oops, I forgot IBMCloud #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
Merged

OCPBUGS-65681: Oops, I forgot IBMCloud #2786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pkg/controller/utils/credentials.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,16 +141,18 @@ func GetClusterPlatform(cd *hivev1.ClusterDeployment) string {
return constants.PlatformAWS
case cd.Spec.Platform.Azure != nil:
return constants.PlatformAzure
case cd.Spec.Platform.BareMetal != nil:
return constants.PlatformBaremetal
Comment on lines +144 to +145
Copy link
Member Author

@2uasimojo 2uasimojo Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ntr: currently unused, retained for, uhh, "completeness".

ntr: alphabetized this list for readability.

case cd.Spec.Platform.GCP != nil:
return constants.PlatformGCP
case cd.Spec.Platform.IBMCloud != nil:
return constants.PlatformIBMCloud
case cd.Spec.Platform.Nutanix != nil:
return constants.PlatformNutanix
case cd.Spec.Platform.OpenStack != nil:
return constants.PlatformOpenStack
case cd.Spec.Platform.VSphere != nil:
return constants.PlatformVSphere
case cd.Spec.Platform.BareMetal != nil:
return constants.PlatformBaremetal
case cd.Spec.Platform.Nutanix != nil:
return constants.PlatformNutanix
}
return constants.PlatformUnknown
}