OCPBUGS-65681: Oops, I forgot IBMCloud

[2uasimojo]

In #2775 we rearranged the way installmanager figures out which platform-specific ConfigureCreds() function to call, but forgot to include IBMCloud in the lookup table. (BareMetal is there, which we don't use, and which is probably why this was missed, as it made the number of entries correct.)

[openshift-ci-robot]

@2uasimojo: This pull request references Jira Issue OCPBUGS-65681, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In HIVE-2302 / #2729 we rearranged the way installmanager figures out which platform-specific ConfigureCreds() function to call, but forgot to include IBMCloud in the lookup table. (BareMetal is there, which we don't use, and which is probably why this was missed, as it made the number of entries correct.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[2uasimojo]

ntr: currently unused, retained for, uhh, "completeness".

ntr: alphabetized this list for readability.

[2uasimojo]

• expected the bug to target the "4.21.0" version, but no target version was set

We don't track with OCP versions, but okay.

/jira refresh

[openshift-ci-robot]

@2uasimojo: This pull request references Jira Issue OCPBUGS-65681, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

• expected the bug to target the "4.21.0" version, but no target version was set

We don't track with OCP versions, but okay.

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[2uasimojo]

Requesting review from QA contact:
/cc @gpei

This should have flagged a hive QE member.

/cc @huangmingxia @jianping-shu

[2uasimojo]

/assign @dlom

[openshift-ci-robot]

@2uasimojo: This pull request references Jira Issue OCPBUGS-65681, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

In #2779 we rearranged the way installmanager figures out which platform-specific ConfigureCreds() function to call, but forgot to include IBMCloud in the lookup table. (BareMetal is there, which we don't use, and which is probably why this was missed, as it made the number of entries correct.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.34%. Comparing base (acea5e9) to head (ca682e0).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/controller/utils/credentials.go	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2786      +/-   ##
==========================================
- Coverage   50.34%   50.34%   -0.01%     
==========================================
  Files         279      279              
  Lines       34167    34169       +2     
==========================================
  Hits        17201    17201              
- Misses      15612    15614       +2     
  Partials     1354     1354              

Files with missing lines	Coverage Δ
pkg/controller/utils/credentials.go	0.00% <0.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[2uasimojo]

This push is just a commit message change. We can bypass CI if we get QE results first.

[dlom]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [2uasimojo,dlom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD acea5e9 and 2 for PR HEAD ca682e0 in total

[openshift-ci]

@2uasimojo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@2uasimojo: Jira Issue OCPBUGS-65681: All pull requests linked via external trackers have merged:

• openshift/hive#2786

Jira Issue OCPBUGS-65681 has been moved to the MODIFIED state.

In response to this:

In #2775 we rearranged the way installmanager figures out which platform-specific ConfigureCreds() function to call, but forgot to include IBMCloud in the lookup table. (BareMetal is there, which we don't use, and which is probably why this was missed, as it made the number of entries correct.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.