Make 2x compression default for faiss.

src/main/java/org/opensearch/knn/index/engine/AbstractMethodResolver.java

@@ -38,7 +38,10 @@ protected CompressionLevel resolveCompressionLevelFromMethodContext(
         // If the context is null, the compression is not configured or the encoder is not defined, return not configured
         // because the method context does not contain this info
         if (isEncoderSpecified(resolvedKnnMethodContext) == false) {
-            return CompressionLevel.x1;
+            if (knnMethodConfigContext.getCompressionLevel() == null) {
+                return CompressionLevel.NOT_CONFIGURED;
+            }
+            return knnMethodConfigContext.getCompressionLevel();
         }
         Encoder encoder = encoderMap.get(getEncoderName(resolvedKnnMethodContext));
         if (encoder == null) {
@@ -109,7 +112,7 @@ protected boolean shouldEncoderBeResolved(KNNMethodContext knnMethodContext, KNN
         // The encoder should not be resolved if:
         // 1. The encoder is specified
         // 2. The compression is x1
-        // 3. The compression is not specified and the mode is not disk-based
+        // 3. The datatype is float
         if (isEncoderSpecified(knnMethodContext)) {
             return false;
         }
@@ -118,11 +121,6 @@ protected boolean shouldEncoderBeResolved(KNNMethodContext knnMethodContext, KNN
             return false;
         }
 
-        if (CompressionLevel.isConfigured(knnMethodConfigContext.getCompressionLevel()) == false
-            && Mode.ON_DISK != knnMethodConfigContext.getMode()) {
-            return false;
-        }
-
         if (VectorDataType.FLOAT != knnMethodConfigContext.getVectorDataType()) {
             return false;
         }

src/main/java/org/opensearch/knn/index/engine/faiss/FaissMethodResolver.java

@@ -185,6 +185,6 @@ private CompressionLevel getDefaultCompressionLevel(KNNMethodConfigContext knnMe
         if (knnMethodConfigContext.getMode() == Mode.ON_DISK) {
             return CompressionLevel.x32;
         }
-        return CompressionLevel.x1;
+        return CompressionLevel.x2;
     }
 }

src/test/resources/data/test_queries_binary_100x128.csv

@@ -1,100 +1,100 @@
--53,97,109,87,117,-42,116,-90,-17,-5,62,-66,2,109,-78,-52
-9,65,-21,87,-58,-75,-29,1,-73,124,12,-102,-86,18,83,91
--72,76,-21,-100,66,-83,-65,61,-71,39,-81,106,27,5,-125,99
-34,-54,5,-3,127,45,13,29,24,-60,-90,-40,69,30,-23,-100
--91,-51,43,78,81,120,-59,-100,-35,-68,-56,-69,-40,16,-110,-28
--123,-123,-15,-25,-16,17,-52,2,86,12,-98,-73,33,78,110,5
--77,-115,-13,-84,4,-13,-32,75,-128,24,-17,-78,28,-57,111,-20
-79,-71,-5,127,-46,-72,118,123,-7,33,-85,95,-61,-121,95,-61
--52,40,-5,11,112,-69,11,-36,-26,78,-16,-33,59,-105,102,-51
-43,48,70,85,-111,-21,34,14,112,98,0,-126,73,127,46,-52
-84,47,-109,-29,72,68,-34,84,-105,64,-73,-71,-111,-35,-79,89
--57,21,69,33,-65,-42,78,106,-18,92,51,29,-109,60,101,100
--20,-36,-126,-22,-122,110,50,47,38,-42,99,32,21,-13,61,-38
--83,36,27,5,127,-115,-87,127,-12,-60,-105,108,60,112,-50,109
-113,34,-57,105,127,-122,70,-86,-111,-95,-112,-75,-72,127,-33,124
-121,-53,-111,113,-87,-106,87,-30,-9,-128,-62,-91,-91,75,-61,83
--4,-110,55,-119,-114,123,95,-9,-28,-8,-55,-117,-77,-96,88,83
-63,-109,107,82,125,24,-72,-89,-1,64,38,70,117,72,1,-27
-38,95,-87,-87,-49,-104,-35,-126,57,-95,-30,-35,-114,-41,-33,-46
--95,6,30,71,-16,-112,83,-90,-118,87,-29,53,-96,-68,125,-73
-58,-47,25,-44,-4,-125,-30,5,-16,-42,107,-42,-68,-97,17,-51
--125,-113,108,-29,57,-48,102,-76,-34,0,-81,-21,113,-13,95,65
--11,-73,38,47,-6,-80,91,39,-4,-26,-43,30,63,12,30,52
--76,124,85,126,-106,-23,52,104,-81,-87,-66,-68,81,40,-99,7
--108,47,-76,-47,110,-28,-49,46,70,25,72,-73,-122,-41,-47,117
-19,27,48,74,-70,-85,-87,-107,-30,-44,92,11,113,-7,42,-16
-35,114,75,-30,-69,115,-94,-116,22,81,-41,120,-64,-115,97,-43
--111,8,83,-62,0,15,-10,-83,63,-96,92,-44,-23,85,78,123
-110,78,-46,105,-40,-63,40,122,-69,-96,23,-90,81,46,122,51
-21,25,-2,51,-115,28,-111,-8,-125,-126,-79,4,99,48,78,-17
-125,-2,57,82,-66,77,-125,-49,16,33,-88,-6,-74,-75,23,1
-82,28,-38,28,23,-26,-9,-1,-68,85,-92,78,100,-118,-120,-9
-90,55,72,67,-50,20,-9,-57,-66,9,-74,-128,81,125,11,37
-109,49,-23,61,89,-12,7,70,64,-111,110,-89,-21,-95,95,118
-31,55,-44,118,50,87,-90,-91,-2,-44,117,109,6,-96,-105,45
-82,13,109,3,-83,-99,36,-115,55,-124,-36,-126,-10,-55,-47,96
-102,-20,84,-41,-59,-112,-54,117,-70,52,31,-118,-70,-108,-80,-27
--42,96,3,6,-17,-56,-113,31,86,2,25,25,91,58,-48,-84
--120,-121,87,-44,121,-27,95,-46,-79,-51,-86,-20,-100,70,51,-88
-118,111,-82,115,48,-108,122,16,66,37,-93,52,106,-59,73,83
-21,-10,101,-68,-73,-42,-25,88,-40,-35,16,62,126,6,17,-109
--49,68,-10,93,107,88,91,-116,-101,-102,77,-82,117,-119,1,102
--92,92,70,-67,17,59,-9,-111,19,-21,-60,-111,-88,-2,61,111
-63,14,92,-76,71,101,87,11,24,69,-116,71,22,-22,-94,114
-122,72,-32,-54,91,14,-59,-87,-97,-45,46,99,-118,-21,124,-82
-44,-101,91,15,-25,-17,109,63,-86,50,-76,-32,-86,-46,-91,70
-89,114,101,-96,57,-27,-71,8,-1,-112,98,-90,90,-111,-50,-110
-58,16,-55,-88,83,-59,-26,-83,92,54,-97,79,108,120,32,68
--39,69,0,109,-39,6,-57,85,-94,-35,107,-127,-54,-43,112,9
-90,88,-25,-58,-14,-23,-46,-37,101,-3,107,81,-52,3,61,-63
-125,9,-4,-55,-56,69,-7,-113,27,69,72,8,-93,97,49,32
--112,20,-68,-14,-68,101,-19,45,28,66,-10,-68,6,6,-8,-105
--89,2,-12,112,48,2,-45,0,-1,25,4,-37,35,-54,16,-44
--92,-85,7,65,-94,121,-26,-53,-23,75,-104,86,-88,74,-83,18
--9,-34,89,-55,41,86,-30,-110,-1,37,67,99,-42,-63,-63,29
-58,-70,81,80,57,-43,-59,6,-22,-36,6,-96,51,-64,-95,54
--24,113,-83,-25,29,-44,89,32,36,7,81,121,75,-10,23,-83
--99,-27,-78,-35,101,-112,0,78,75,-38,-34,-111,-65,110,27,8
-87,-98,45,91,6,64,100,19,-7,51,-78,51,25,13,-78,92
--126,54,-96,-38,-105,91,-93,-61,118,95,60,28,123,0,105,10
--56,95,-60,78,2,65,-28,10,-19,-6,-49,101,-85,-80,98,-124
--62,50,-39,-48,31,-50,-117,-46,-82,-81,34,16,-15,-83,-114,-117
-98,-75,121,117,-127,70,82,113,97,99,119,-56,-52,5,45,58
-3,-12,-33,-41,77,22,-92,120,-119,-112,-85,41,-107,123,53,-11
--121,90,-55,48,-32,-12,-91,108,23,18,10,-92,-3,26,58,-126
-89,-77,-33,110,115,41,99,-68,-3,37,-52,-43,-39,-76,-107,31
--68,-72,-2,63,91,-113,-109,41,-11,65,-71,-37,-1,82,70,-88
--70,-47,-11,18,53,-49,-63,-10,66,-65,-125,65,118,-70,-34,-24
--63,105,-112,34,91,-119,45,127,76,35,11,121,39,-52,-118,-7
-97,32,-102,-96,42,-94,106,77,-30,69,-92,-100,104,29,127,-31
--119,35,81,124,50,-8,-53,60,-99,118,-128,29,-31,-123,-27,76
-39,-108,-12,78,-100,-21,10,-12,21,-27,-56,124,113,-30,89,-76
--39,30,-21,-77,107,-95,-18,-44,115,-32,108,100,-84,0,-45,85
-34,4,50,-58,-20,74,-60,-77,-117,66,-36,115,24,34,-88,32
-63,4,-56,19,104,105,21,18,108,-104,63,50,-61,50,-11,21
--105,-122,-67,-53,-7,73,11,-61,-71,24,57,-120,82,-31,55,-81
--66,112,86,-2,48,-9,55,-49,-58,67,109,82,-84,-47,-15,117
--8,32,-101,83,103,-10,-125,-69,32,-93,-51,8,6,-12,-10,-39
--70,20,-52,48,-91,-108,26,-116,-117,8,123,-127,69,-35,56,76
-114,90,-80,38,5,43,67,115,-36,103,-56,49,-88,58,-45,-115
-4,-43,-33,114,20,113,-76,83,26,118,-106,-57,123,126,50,-82
--72,-51,-53,-41,113,-126,-35,-63,65,-94,43,-123,-67,-59,-13,18
-30,93,-126,52,-114,-124,45,125,19,93,-64,-112,36,-34,-52,-100
--45,30,102,-60,22,-82,74,115,-78,-15,-116,114,1,54,99,-26
-117,-117,-90,-74,35,-81,-85,-16,115,-71,112,102,-105,26,50,41
-119,126,76,-75,85,-74,86,-63,39,-14,113,-25,-17,61,69,-125
-48,64,-118,-97,-101,-79,105,-103,7,6,44,75,-128,-72,-27,-20
--126,55,67,70,12,-59,-117,-10,-43,-126,75,58,20,-107,65,-15
-47,-37,32,32,-93,26,80,32,39,-1,-60,28,104,126,-22,-128
-53,-83,26,67,-17,-56,33,69,48,31,-60,-112,106,-8,8,109
--65,-34,36,96,-49,110,38,59,20,-9,-104,111,81,46,-125,98
--128,88,-124,-56,-47,3,58,-50,-38,-117,42,-88,-44,-128,103,-85
--106,-93,29,-112,-13,-93,-12,25,73,-8,10,88,122,27,25,30
-16,-107,36,-12,90,-11,91,-103,103,126,122,-45,120,69,-64,-82
--36,-5,58,80,-40,99,-73,-29,121,118,-39,109,111,7,83,-27
--26,43,32,-76,30,-110,18,-103,-79,-26,-101,1,-36,-82,65,-15
-85,-117,83,53,-111,-96,-79,52,125,-112,100,118,82,56,-31,0
-65,73,-12,1,57,103,47,-100,-38,-27,48,-108,-2,-114,-68,-67
-26,-120,-37,-126,-101,14,24,-2,124,-31,-84,73,74,-77,-123,-75
--34,100,-44,-5,-102,-98,57,90,29,98,15,-90,110,114,93,0
+-23,-28,-3,-76,102,-22,-115,-30,71,71,116,-86,-120,113,-111,114
+-115,-86,-33,-22,-118,-7,-90,-92,44,108,28,-25,-117,-97,-2,-1
+-92,113,35,125,6,99,-63,-59,-62,59,-39,108,-92,101,119,26
+-27,99,38,126,0,-17,53,-19,-28,102,79,-104,114,-21,95,69
+-17,61,41,12,87,101,119,57,1,3,91,-17,-18,32,114,105
+-24,20,122,-74,40,-113,51,-105,84,-74,85,106,-20,93,-82,-113
+20,34,-104,-38,5,-80,18,117,-127,3,-63,-19,36,102,55,-27
+96,12,8,74,-47,102,-66,-89,29,-16,-103,10,112,-39,71,-109
+111,-17,112,-31,-23,-19,114,-82,-59,93,25,-96,-62,50,81,-54
+119,97,-75,-81,127,54,110,-77,115,120,-4,79,55,-47,-2,123
+105,46,-64,-105,2,-64,10,-108,9,2,99,56,-72,120,-81,70
+109,-117,-52,-95,66,-88,-36,-92,118,-40,15,48,-8,120,-110,-16
+48,-102,69,107,-44,89,76,-28,44,116,45,-107,-35,44,-82,85
+87,-106,81,61,96,-19,109,4,-68,38,-91,-25,-13,90,-57,-31
+74,-120,-2,-28,-13,-62,-4,60,45,83,46,41,84,19,101,102
+96,-49,3,-53,75,-60,42,53,-70,125,-20,-43,48,-72,14,-62
+76,53,-46,-25,-93,-49,47,-15,-31,-88,122,89,40,95,-85,17
+36,105,-51,63,76,112,47,-80,69,37,121,27,-116,106,-100,34
+73,-92,7,-70,-83,17,-8,-24,82,61,113,112,109,-95,59,3
+15,27,-82,102,12,75,-44,-100,11,78,26,-85,5,41,-87,-55
+-20,-60,98,100,-101,7,73,114,64,-128,-6,52,94,-6,23,-44
+-34,-108,-107,-53,-120,85,-63,-54,-58,-3,53,-53,-66,102,23,-60
+-100,-68,45,-91,-124,121,-83,-37,80,-65,-82,83,101,-25,70,-48
+-62,39,-9,-72,-12,20,-89,84,96,23,64,-107,126,-39,116,39
+-106,85,-104,-37,-4,5,15,-51,-40,-53,81,64,106,-85,-89,-38
+-110,-47,-107,-65,65,39,-79,-21,23,7,91,126,-85,80,-108,-46
+-25,108,-56,50,-35,-118,26,-15,-109,-127,57,-5,-37,12,40,-118
+-95,-45,-14,-116,-36,72,25,127,11,-109,-120,-28,-2,90,-15,-33
+94,-6,110,19,4,-114,-81,-18,0,-15,-81,43,50,-21,103,48
+116,-26,3,-5,12,71,55,-72,-97,13,-98,62,-119,-102,-121,43
+-4,-48,-9,34,34,-82,82,-125,-74,114,36,49,-58,-108,-32,1
+55,-38,-24,-91,-113,82,41,-78,-63,109,2,-47,52,41,-117,-125
+119,87,2,-4,11,47,45,-32,-112,108,-7,53,95,75,-67,-98
+41,-73,106,56,-51,9,120,88,34,-15,-23,-41,45,27,75,91
+-87,-75,-83,65,122,-99,63,85,-120,-11,-107,50,42,7,10,-69
+14,-57,-92,-62,-71,-123,-37,108,-73,46,-83,-10,-97,69,90,-57
+56,-114,80,-77,64,-9,51,-82,-3,-126,75,-37,4,15,37,12
+94,-82,56,59,105,120,-126,-61,-116,-116,49,-108,45,69,7,76
+7,-112,103,-85,93,-25,-128,53,28,-62,35,59,-115,-80,-10,121
+54,-117,-100,-72,-28,79,114,-117,-66,86,-71,-109,64,5,-125,67
+50,70,86,-126,-50,-2,-81,-73,98,36,-50,104,-63,-17,-117,8
+95,7,4,-12,126,80,39,-20,-63,-83,106,59,118,-124,-127,-65
+21,-33,-113,48,-89,-3,124,36,35,-19,-87,68,32,-96,117,-48
+12,-53,-112,52,-22,53,-65,-65,-18,-34,-90,48,41,47,-23,123
+-36,98,55,-107,-64,42,86,85,41,-73,34,-47,-109,-102,114,18
+121,-109,113,-72,-117,2,47,56,-124,-60,-91,-103,-128,-103,83,-39
+-95,-9,75,-80,-89,13,44,-3,89,-53,29,63,-87,102,9,-63
+64,36,95,60,113,-99,-48,74,-96,-106,40,-128,-15,122,41,-72
+45,-122,100,33,-104,57,28,-1,62,45,-101,0,-50,-82,-86,-6
+84,-4,24,66,126,-27,11,51,71,-8,-42,-59,-41,-72,-116,-42
+-108,21,-113,-3,-7,-102,-102,-91,-99,-3,59,-53,-28,32,36,107
+-51,-44,-79,-24,20,19,15,55,-57,-13,-117,-77,29,-122,-2,101
+-19,10,48,32,-103,67,0,88,30,118,-17,-26,-41,-88,-74,92
+-71,85,89,57,-22,-51,-64,-90,-107,36,109,102,13,96,-17,34
+-60,105,112,89,36,16,-109,-102,16,-34,-44,93,-41,108,-80,-17
+-27,-92,-62,88,119,-39,-109,50,72,-53,126,-78,106,54,-71,60
+97,-89,62,-23,-118,-28,8,28,-51,93,-49,54,62,86,-47,-24
+66,-124,79,-63,-72,-80,59,127,7,-6,-115,16,23,112,-48,64
+63,-8,64,107,-63,-28,94,9,-29,21,30,125,84,-42,115,106
+-58,45,16,32,35,115,-71,67,-26,100,89,-110,116,-66,-119,124
+79,-95,-120,-60,-124,91,115,50,55,-127,79,-67,-68,-11,64,-59
+-66,-19,98,79,111,-76,-38,-93,-17,8,-63,-31,125,70,75,-82
+-16,-72,-90,93,-95,-26,40,-12,-61,0,14,13,5,-24,8,105
+51,85,-107,56,-3,-90,13,-12,-34,123,-46,-63,102,-104,66,32
+44,-39,92,-22,5,-14,28,23,-54,9,87,8,30,119,118,43
+-55,3,-7,-92,29,-117,-65,125,-73,111,19,76,-53,29,29,74
+-5,-35,75,98,84,-103,-116,-49,-110,60,-8,109,18,72,-49,-89
+-52,-109,27,-5,65,-62,32,-98,-72,17,-42,-19,-121,91,119,8
+100,-10,-11,-83,-56,45,32,104,-117,66,-33,-33,2,-121,-13,10
+88,14,-58,87,-117,-115,96,-104,-94,-77,-127,81,85,-110,68,-19
+100,-64,-13,-3,-4,-67,-119,17,-19,-55,44,-40,93,71,89,-8
+113,-94,111,-12,-30,76,-49,110,75,-6,-19,111,-99,16,-128,64
+1,-65,41,-125,37,15,20,-88,-112,12,-84,47,-93,111,25,108
+38,-7,-34,48,-64,100,-86,53,-56,91,-105,-53,-25,-81,49,-9
+35,-16,-6,47,56,-38,-46,81,61,73,-94,113,-35,-23,-95,105
+37,81,-48,53,-41,85,-64,-27,-71,8,-35,40,-52,-114,23,-124
+68,120,-98,-75,-78,-98,-114,-109,-81,64,-3,-76,95,88,117,-107
+-115,-34,89,29,53,121,-33,-13,104,-21,-66,125,-80,32,18,50
+-98,36,101,107,70,-118,110,-123,-63,-17,-33,-80,18,-65,-4,-80
+-45,-81,0,18,50,-18,-63,37,90,-67,-55,-6,49,38,-86,-72
+-117,46,35,93,-22,96,-121,97,84,-77,-105,33,106,1,4,65
+69,-20,-6,-93,19,106,103,8,-20,-27,-6,12,105,118,57,26
+-128,72,52,-50,35,122,-104,-49,-62,-85,-6,1,-40,-106,110,98
+18,-30,46,82,38,-12,-94,-66,73,-76,2,-122,45,-99,-21,-126
+-51,7,-19,56,91,-48,39,119,-44,123,23,126,2,-46,25,-31
+41,-11,-2,37,92,-122,25,-89,-6,24,-72,5,-98,106,-80,30
+11,61,-89,-109,65,17,96,-99,-127,38,100,-66,-103,67,-127,106
+-1,63,9,76,-32,-42,-78,-55,69,41,-98,49,102,-29,-46,125
+58,70,-16,-114,104,93,53,-104,-114,107,19,0,-97,50,116,-76
+126,83,124,46,-5,-61,-46,-54,-12,-9,-31,-2,-28,-118,-116,55
+82,44,33,67,-58,31,-52,70,61,85,52,-68,-95,-3,79,85
+15,111,91,-83,18,-67,-8,-107,112,90,-11,-93,-110,39,41,104
+-28,-81,69,42,103,48,121,-69,-58,81,-39,-108,-59,-30,-45,-116
+91,-122,-15,-65,32,-82,-75,15,30,36,84,30,-91,-107,86,-25
+-100,94,72,30,-105,115,22,85,-77,120,-43,-61,78,75,111,55
+-79,110,57,-32,-34,-60,102,8,-19,55,-58,-87,-113,-21,-57,9
+-89,93,-61,-16,-38,68,108,104,-32,-44,-125,31,-112,33,-100,118
+-117,-83,-32,43,114,34,-9,126,28,-78,-88,32,32,-83,-44,117
+-53,-76,9,63,75,-22,61,41,15,-52,113,31,69,-102,-34,-100
+-91,-18,109,19,119,-72,27,-19,-127,19,68,-114,-91,78,1,-85