Skip to content

Conversation

@MrFlap
Copy link
Contributor

@MrFlap MrFlap commented Oct 14, 2025

Description

Make 2x compression default for faiss. Change the testing dataset so that the vectors won't be clipped.

Related Issues

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…that the vectors won't be clipped.

Signed-off-by: Andrew Klepchick <[email protected]>
@0ctopus13prime
Copy link
Collaborator

Hi @MrFlap, thank you for raising PR.
I think we should get align on what would be the 'default' settings for Faiss engine.
With this change, we will give 2x compression for ivf, and do we want to give 2x for all methods including hnsw + ivf in Faiss?

@MrFlap
Copy link
Contributor Author

MrFlap commented Oct 14, 2025

Hey @0ctopus13prime, I think that should be fine, right? Unless we see somewhere that IVF has a significant recall or throughput drop when using fp16.

@0ctopus13prime
Copy link
Collaborator

0ctopus13prime commented Oct 15, 2025

@MrFlap
It's not my call 😅
I think we should make it clear in here whether if the direction is the one that we want to go.
It's clear for us to make FP16 default for HNSW as LuceneOnFaiss is coming up, but for IVF, not sure we have aligned on the benefits yet. Just saying that we need to make it clear that we want to make FP16 default for all.

cc @navneet1v @shatejas @vamshin @Vikasht34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants